Skip to content

[minor bugfix] fix minor bug with handleReset in suspense fixture#13843

Merged
nhunzaker merged 3 commits intofacebook:masterfrom
swyxio:patch-1
Oct 21, 2018
Merged

[minor bugfix] fix minor bug with handleReset in suspense fixture#13843
nhunzaker merged 3 commits intofacebook:masterfrom
swyxio:patch-1

Conversation

@swyxio
Copy link
Copy Markdown
Contributor

@swyxio swyxio commented Oct 12, 2018

otherwise resetting the cache in debugger throws an error

reported here
https://www.reddit.com/r/reactjs/comments/9n9nfo/react_166_canary/

Before submitting a pull request, please make sure the following is done:

  1. Fork the repository and create your branch from master.
  2. Run yarn in the repository root.
  3. If you've fixed a bug or added code that should be tested, add tests!
  4. Ensure the test suite passes (yarn test). Tip: yarn test --watch TestName is helpful in development.
  5. Run yarn test-prod to test in the production environment. It supports the same options as yarn test.
  6. If you need a debugger, run yarn debug-test --watch TestName, open chrome://inspect, and press "Inspect".
  7. Format your code with prettier (yarn prettier).
  8. Make sure your code lints (yarn lint). Tip: yarn linc to only check changed files.
  9. Run the Flow typechecks (yarn flow).
  10. If you haven't already, complete the CLA.

Learn more about contributing: https://reactjs.org/docs/how-to-contribute.html

@sizebot
Copy link
Copy Markdown

sizebot commented Oct 12, 2018

Details of bundled changes.

Comparing: c9be16f...c27a811

scheduler

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
scheduler.development.js n/a n/a 0 B 19.17 KB 0 B 5.74 KB UMD_DEV
scheduler.production.min.js n/a n/a 0 B 3.16 KB 0 B 1.53 KB UMD_PROD

Generated by 🚫 dangerJS

@gaearon
Copy link
Copy Markdown
Collaborator

gaearon commented Oct 12, 2018

This should probably pass performance.now()?

@swyxio
Copy link
Copy Markdown
Contributor Author

swyxio commented Oct 16, 2018

not sure what that performance.now() reference means.. the fixture just crashes on clearing cache without this PR

@chasestarr
Copy link
Copy Markdown

i believe the suggestion is to provide the timestamp to unstable_trace using performance.now() rather than new Date()

@swyxio
Copy link
Copy Markdown
Contributor Author

swyxio commented Oct 16, 2018

thanks @chasestarr :)

@nhunzaker nhunzaker merged commit 7ebd90c into facebook:master Oct 21, 2018
@nhunzaker
Copy link
Copy Markdown
Contributor

Looks good to me. Thanks!

linjiajian999 pushed a commit to linjiajian999/react that referenced this pull request Oct 22, 2018
…cebook#13843)

* fix minor bug with handleReset in suspense fixture

otherwise resetting the cache in debugger throws an error 

reported here
https://www.reddit.com/r/reactjs/comments/9n9nfo/react_166_canary/

* fix singlequote/doublequote

* switch to performance.now()
jetoneza pushed a commit to jetoneza/react that referenced this pull request Jan 23, 2019
…cebook#13843)

* fix minor bug with handleReset in suspense fixture

otherwise resetting the cache in debugger throws an error 

reported here
https://www.reddit.com/r/reactjs/comments/9n9nfo/react_166_canary/

* fix singlequote/doublequote

* switch to performance.now()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants