[minor bugfix] fix minor bug with handleReset in suspense fixture#13843
Merged
nhunzaker merged 3 commits intofacebook:masterfrom Oct 21, 2018
Merged
[minor bugfix] fix minor bug with handleReset in suspense fixture#13843nhunzaker merged 3 commits intofacebook:masterfrom
nhunzaker merged 3 commits intofacebook:masterfrom
Conversation
otherwise resetting the cache in debugger throws an error reported here https://www.reddit.com/r/reactjs/comments/9n9nfo/react_166_canary/
Details of bundled changes.Comparing: c9be16f...c27a811 scheduler
Generated by 🚫 dangerJS |
Collaborator
|
This should probably pass |
Contributor
Author
|
not sure what that |
|
i believe the suggestion is to provide the timestamp to |
Contributor
Author
|
thanks @chasestarr :) |
Contributor
|
Looks good to me. Thanks! |
linjiajian999
pushed a commit
to linjiajian999/react
that referenced
this pull request
Oct 22, 2018
…cebook#13843) * fix minor bug with handleReset in suspense fixture otherwise resetting the cache in debugger throws an error reported here https://www.reddit.com/r/reactjs/comments/9n9nfo/react_166_canary/ * fix singlequote/doublequote * switch to performance.now()
jetoneza
pushed a commit
to jetoneza/react
that referenced
this pull request
Jan 23, 2019
…cebook#13843) * fix minor bug with handleReset in suspense fixture otherwise resetting the cache in debugger throws an error reported here https://www.reddit.com/r/reactjs/comments/9n9nfo/react_166_canary/ * fix singlequote/doublequote * switch to performance.now()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
otherwise resetting the cache in debugger throws an error
reported here
https://www.reddit.com/r/reactjs/comments/9n9nfo/react_166_canary/
Before submitting a pull request, please make sure the following is done:
master.yarnin the repository root.yarn test). Tip:yarn test --watch TestNameis helpful in development.yarn test-prodto test in the production environment. It supports the same options asyarn test.yarn debug-test --watch TestName, openchrome://inspect, and press "Inspect".yarn prettier).yarn lint). Tip:yarn lincto only check changed files.yarn flow).Learn more about contributing: https://reactjs.org/docs/how-to-contribute.html