React Events: fix cancel events for Press#15563
Merged
necolas merged 1 commit intofacebook:masterfrom May 3, 2019
Merged
Conversation
necolas
force-pushed
the
react-events/fix-press-cancel
branch
from
402b3a0 to
09e6a53
Compare
trueadm
approved these changes
May 3, 2019
Contributor
trueadm
left a comment
trueadm
left a comment
There was a problem hiding this comment.
Needs a test for cancelling with longPress (or another async event). We ran into issues before with root event collision from async events, so would be good to ensure the cancel logic doesn't regress with them too.
necolas
force-pushed
the
react-events/fix-press-cancel
branch
from
09e6a53 to
cf76bf9
Compare
necolas
force-pushed
the
react-events/fix-press-cancel
branch
from
cf76bf9 to
315aef1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dragstartevent as a proxy for cancellation (i.e., the event dispatched when move-during-press occurs on an anchor tag)Ref #15257