Fix interaction tracing for batched update mounts#15567
Merged
bvaughn merged 2 commits intofacebook:masterfrom May 6, 2019
Merged
Fix interaction tracing for batched update mounts#15567bvaughn merged 2 commits intofacebook:masterfrom
bvaughn merged 2 commits intofacebook:masterfrom
Conversation
bvaughn
changed the title
bvaughn
requested review from
acdlite,
gaearon and
threepointone
and removed request for
acdlite and
threepointone
threepointone
approved these changes
May 5, 2019
Contributor
threepointone
left a comment
threepointone
left a comment
There was a problem hiding this comment.
Approving because it makes sense to me, but deferring to @acdlite’s veto because he’s just so cool
bvaughn
commented
May 5, 2019
| }, | ||
| "devEngines": { | ||
| "node": "8.x || 9.x || 10.x || 11.x" | ||
| "node": "8.x || 9.x || 10.x || 11.x || 12.x" |
Contributor
Author
There was a problem hiding this comment.
This wasn't strictly necessary ^ but... 🤷♂
acdlite
approved these changes
May 6, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a root is mounting inside of a batched update (including the
acttest helper) the interactionsSetin ofReactFiberScheduleris empty. This does not impact updates, only mounts.The reason for this is that in that case, we never recorded the pending interactions on the root.
Technically the bug was related to batched updates, not
act, but it seemed worth adding test coverage for both just in case there were changes in the future.I came across this while trying to write profiling tests for the new DevTools (bvaughn/react-devtools-experimental#258). I've tested this change in that PR and verified that it fixes the disconnected interactions.
Resolves #15566