Event API: add key modifiers to Press events#15611
Merged
trueadm merged 1 commit intofacebook:masterfrom May 10, 2019
Merged
Conversation
Details of bundled changes.Comparing: 3d8b836...4de3f4e react-events
Generated by 🚫 dangerJS |
|
|
||
| if (event) { | ||
| const nativeEvent = (event.nativeEvent: any); | ||
| ({altKey, ctrlKey, metaKey, shiftKey} = nativeEvent); |
Contributor
There was a problem hiding this comment.
why the extra () here? prettier?
Contributor
Author
There was a problem hiding this comment.
You need it, otherwise it doesn't assign to those bindings. Prettier will add them in anyway.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds keyboard modifier booleans (
altKey,altKey,metaKeyandshiftKey) to Press events, so user-land gets access to this information. Furthermore, I also addedxandyto Press events too (alias forclientXandclientY).