Rename ReactFiberScheduler -> ReactFiberWorkLoop and extract throwException from Unwind#15725
Merged
acdlite merged 2 commits intofacebook:masterfrom May 23, 2019
Merged
Rename ReactFiberScheduler -> ReactFiberWorkLoop and extract throwException from Unwind#15725acdlite merged 2 commits intofacebook:masterfrom
acdlite merged 2 commits intofacebook:masterfrom
Conversation
The scheduling part is mostly extracted out to the scheduler package. What's remaining is mostly around the loop around each section of work. I name it something with Work in it because it's very related to the BeginWork, CompleteWork and UnwindWork sections.
Our throwing works more like algebraic effects in that it's a separate phase where we find a handler and we later unwind.
acdlite
reviewed
May 23, 2019
| } while (workInProgress !== null); | ||
| } | ||
|
|
||
| export {throwException, createRootErrorUpdate, createClassErrorUpdate}; |
Collaborator
There was a problem hiding this comment.
Any reason for putting the exports at the bottom? We're really inconsistent about this. Maybe we should pick one and stick with it.
Contributor
Author
There was a problem hiding this comment.
This is just copy pasta so at least it's consistent with what it was.
I think the primary reason exports at the bottom are left over from the CommonJS form.
acdlite
approved these changes
May 23, 2019
|
No significant bundle size changes to report. Generated by 🚫 dangerJS |
|
L
Sent from Yahoo Mail on Android
On Thu, May 23, 2019 at 5:37 PM, Sebastian Markbåge<notifications@github.com> wrote:
@sebmarkbage commented on this pull request.
In packages/react-reconciler/src/ReactFiberThrow.js:
+ workInProgress,
+ errorInfo,
+ renderExpirationTime,
+ );
+ enqueueCapturedUpdate(workInProgress, update);
+ return;
+ }
+ break;
+ default:
+ break;
+ }
+ workInProgress = workInProgress.return;
+ } while (workInProgress !== null);
+}
+
+export {throwException, createRootErrorUpdate, createClassErrorUpdate};
This is just copy pasta so at least it's consistent with what it was.
I think the primary reason exports at the bottom are left over from the CommonJS form.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
NMinhNguyen
referenced
this pull request
in enzymejs/react-shallow-renderer
Jan 29, 2020
…eption from Unwind (#15725) * Rename ReactFiberScheduler to ReactFiberWorkLoop The scheduling part is mostly extracted out to the scheduler package. What's remaining is mostly around the loop around each section of work. I name it something with Work in it because it's very related to the BeginWork, CompleteWork and UnwindWork sections. * Extract throwException from UnwindWork Our throwing works more like algebraic effects in that it's a separate phase where we find a handler and we later unwind.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This has been bothering me for a while.