[Flare] Move unstable_createEventComponent to ReactDOM#15890
Merged
trueadm merged 5 commits intofacebook:masterfrom Jun 18, 2019
Merged
[Flare] Move unstable_createEventComponent to ReactDOM#15890trueadm merged 5 commits intofacebook:masterfrom
trueadm merged 5 commits intofacebook:masterfrom
Conversation
|
React: size: -0.3%, gzip: -0.2% Details of bundled changes.Comparing: 353e0ee...502316d react
react-events
react-dom
Generated by 🚫 dangerJS |
sebmarkbage
reviewed
Jun 14, 2019
sebmarkbage
reviewed
Jun 14, 2019
| entry: 'react-events/press', | ||
| global: 'ReactEventsPress', | ||
| externals: ['react'], | ||
| externals: ['react-dom'], |
Contributor
There was a problem hiding this comment.
I believe this means that we should add it as a dep in the package.json.
https://github.com/facebook/react/blob/master/packages/react-events/package.json#L40
I know yarn pnp relied on this package information for module resolution.
That's unfortunate since it's not a dep for the whole package. Just when used in a DOM environment. Not sure how mixed RN / web code deals with this. cc @necolas
Contributor
Author
There was a problem hiding this comment.
This isn't a big deal for now. We aren't going to be publishing react-events anytime soon. This was one of the reasons I tried to avoid this approach to begin with, but we could get around this with some kind of build step, it just means that these can't really ever go in react, but must be their own separate package – otherwise react will pull in ever renderer out there.
trueadm
force-pushed
the
split-responders-by-renderer
branch
from
1f82973 to
e4ce62d
Compare
sebmarkbage
approved these changes
Jun 18, 2019
rickhanlonii
pushed a commit
to rickhanlonii/react
that referenced
this pull request
Jun 25, 2019
NMinhNguyen
referenced
this pull request
in enzymejs/react-shallow-renderer
Jan 29, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does two things:
React.unstable_createEventComponenttoReactDOM.unstable_createEventComponent.