[Bugfix] Check tag before calling hook effects#16215
Merged
acdlite merged 2 commits intofacebook:masterfrom Jul 26, 2019
Merged
[Bugfix] Check tag before calling hook effects#16215acdlite merged 2 commits intofacebook:masterfrom
acdlite merged 2 commits intofacebook:masterfrom
Conversation
gaearon
reviewed
Jul 26, 2019
gaearon
approved these changes
Jul 26, 2019
Collaborator
gaearon
left a comment
gaearon
left a comment
There was a problem hiding this comment.
Accept to unblock but we need to fix DEV case too + test
|
No significant bundle size changes to report. Generated by 🚫 dangerJS |
acdlite
force-pushed
the
check-tag-passive-effects
branch
from
96d8d2b to
8a00b67
Compare
Next commit fixes it.
acdlite
force-pushed
the
check-tag-passive-effects
branch
from
8a00b67 to
a59be45
Compare
acdlite
added a commit
to acdlite/react
that referenced
this pull request
Jul 26, 2019
Next commit fixes it.
acdlite
force-pushed
the
check-tag-passive-effects
branch
2 times, most recently
from
1f88498 to
8080fb7
Compare
acdlite
added a commit
to acdlite/react
that referenced
this pull request
Jul 26, 2019
Next commit fixes it.
acdlite
force-pushed
the
check-tag-passive-effects
branch
from
8080fb7 to
563fe76
Compare
TODO: Test that triggers this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a missing tag check before calling passive effects.
The reason we didn't catch this earlier is because it happens to accidentally work even without the check in most cases.
I added a regression test but it's very specific and weird and you should feel free to delete it later if the implementation details change and it causes you problems. I split this into the first commit to show that the test fails.
The second commit adds the tag check, to show that it fixes the test.