Skip to content

Conversation

@benjamn
Copy link
Contributor

@benjamn benjamn commented Jul 5, 2013

The 755 mode corresponds to a UNIX mode string of -rwxr-xr-x.

Closes #166.

@benjamn
Copy link
Contributor Author

benjamn commented Jul 5, 2013

Merging with prejudice.

benjamn added a commit that referenced this pull request Jul 5, 2013
…ility

Ensure that the phantomjs binary has appropriate UNIX mode
@benjamn benjamn merged commit 826d603 into facebook:master Jul 5, 2013
@benjamn benjamn deleted the issue-166-fix-phantomjs-executability branch July 5, 2013 23:18
@zpao
Copy link
Member

zpao commented Jul 5, 2013

I kinda wish we instead set a max version for phantom where it didn't have this bug instead of working around an issue that will go away (and hopefully soon). We're going to forget to take that code out.

@benjamn
Copy link
Contributor Author

benjamn commented Jul 5, 2013

@zpao we can do "~1.9.0" (which is a good idea, since right now we have >=), but I think that will still match the bad version: 1.9.1-1.

@zpao
Copy link
Member

zpao commented Jul 5, 2013

Well, we could match exactly here - "1.9.1" - or we could use a range - ">=1.9.0 <1.9.1-1". And when it got fixed we could switch to "~1.9.1-2" (maybe, might need to do something different there, but you can || ranges, so maybe just add || >=1.9.1-2

Full reference for version matching: https://npmjs.org/doc/json.html#dependencies

@benjamn
Copy link
Contributor Author

benjamn commented Jul 5, 2013

Looks like we can't have || >=1.9.1-2 until that version actually exists, super lame.

@zpao
Copy link
Member

zpao commented Jul 6, 2013

Looks like you can do it the other way (">=1.9.1-2 || ..."), but we probably don't want to specify a version that we don't actually know works anyway :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix tests when using phantomjs 1.9.1-1

2 participants