Added missing Flow type coverage to DevTools context menu#17733
Merged
bvaughn merged 1 commit intofacebook:masterfrom Dec 29, 2019
Merged
Added missing Flow type coverage to DevTools context menu#17733bvaughn merged 1 commit intofacebook:masterfrom
bvaughn merged 1 commit intofacebook:masterfrom
Conversation
The param should probably be a generic type, but I'm not sure how to satisfy Flow with the current top-level Map. At least this adds basic coverage (which was missing before, oops).
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 23a7650:
|
threepointone
approved these changes
Dec 28, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Oops. We should probably have a lint rule that complains if we forget to add the copyright+flow boilerplate to new files.
The
dataparam should probably be a generic type, but I'm not sure how to satisfy Flow with the current top-levelidToShowFnMapMap. At least this adds basic coverage (which was missing before, oops).