Updated release script documentation and command names#17929
Updated release script documentation and command names#17929bvaughn merged 3 commits intofacebook:masterfrom
Conversation
facebook-github-bot
added
CLA Signed
React Core Team
|
|
||
| ```sh | ||
| scripts/release/publish.js --tags next latest | ||
| scripts/release/publish.js --tags latest |
There was a problem hiding this comment.
Note this is arguably a significant change. If "next" releases are identified as always being 0.0.0-, and "latest" releases are always semver numbers, it doesn't make sense for us to update next to match latest on a stable release. I think that's fine though.
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 39baee9:
|
| if (tags.includes('next')) { | ||
| console.log( | ||
| theme`{error Stable release} {version ${version}} {error cannot be tagged as} {tag canary}` | ||
| theme`{error Stable release} {version ${version}} {error cannot be tagged as} {tag next}` |
There was a problem hiding this comment.
This goes with my other comment about preventing us from tagging a semver range as next. If others feel we should relax this constraint, I could undo this check.
threepointone
left a comment
threepointone
left a comment
There was a problem hiding this comment.
I love how all the additional quotes makes it sound sarcastic. Yeah sure, that's our [excessive bunny quotes] "next" release.
While I don't feel strongly about not tagging semver releases with next, I'll admit it does feel odd. No harm in trying it out for a while though. As long as we publish next releases regularly.
scripts/release/README.md
Outdated
| This script prompts for new (stable) release versions for each public package and updates the package contents (both `package.json` and inline version numbers) to match. It also updates inter-package dependencies to account for the new versions. | ||
|
|
||
| Canary release have already been tested but it is still a good idea to **manually test and verify a release** before publishing to ensure that e.g. version numbers are correct. Upon completion, this script prints manual testing instructions. | ||
| Next release have already been tested but it is still a good idea to **manually test and verify a release** before publishing to ensure that e.g. version numbers are correct. Upon completion, this script prints manual testing instructions. |
There was a problem hiding this comment.
| Next release have already been tested but it is still a good idea to **manually test and verify a release** before publishing to ensure that e.g. version numbers are correct. Upon completion, this script prints manual testing instructions. | |
| This release has already been tested, but it is still a good idea to **manually test and verify a release** before publishing to ensure that e.g. version numbers are correct. Upon completion, this script prints manual testing instructions. |
Co-Authored-By: Sunil Pai <threepointone@oculus.com>
6 participants
Updated our team's release script documentation and command names to match what our public release channel process says.
--dryon for publishing) to make sure everything still works.