Clean up modern plugins to remove dead code#18639
Merged
trueadm merged 1 commit intofacebook:masterfrom Apr 16, 2020
Merged
Conversation
facebook-github-bot
added
CLA Signed
React Core Team
trueadm
force-pushed
the
cleanup-modern-event-plugins
branch
from
95cf6d2 to
81618f3
Compare
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 3c39940:
|
Remove names
Details of bundled changes.Comparing: b1a0831...3c39940 react-dom
ReactDOM: size: 0.0%, gzip: 0.0% Size changes (stable) |
trueadm
force-pushed
the
cleanup-modern-event-plugins
branch
from
81618f3 to
3c39940
Compare
Details of bundled changes.Comparing: b1a0831...3c39940 react-dom
ReactDOM: size: 0.0%, gzip: 0.0% Size changes (experimental) |
necolas
approved these changes
Apr 16, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a cut out of #18615, so we break down the amount of changes in that PR, but have the same end goal. Furthermore, this PR requires #18638 to land before the CI will pass as this PR removes some files that are dead once that PR is merged.
This PR removes the non-modern event system paths (dead code) from the modern event plugin modules. It also inlines the following modules into
DOMModernPluginEventSystem, to show they belong with that specific event system only:This also means we don't need to export internals of the
DOMModernPluginEventSystemused foruseEventandEventTargetinstances. Lastly, I made sure all the modern event test files set the modern event system flag to be enabled as per outlined in #18615.