Remove dynamic modern event system flag for FB#19059
Merged
trueadm merged 2 commits intofacebook:masterfrom Jun 11, 2020
Merged
Remove dynamic modern event system flag for FB#19059trueadm merged 2 commits intofacebook:masterfrom
trueadm merged 2 commits intofacebook:masterfrom
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit f0a564d:
|
facebook-github-bot
added
React Core Team
Details of bundled changes.Comparing: 1d85bb3...f0a564d react-dom
Size changes (experimental) |
Details of bundled changes.Comparing: 1d85bb3...f0a564d react-dom
Size changes (stable) |
sebmarkbage
approved these changes
Jun 11, 2020
| 'react-dom/server': HAS_NO_SIDE_EFFECTS_ON_IMPORT, | ||
| 'react/jsx-dev-runtime': HAS_NO_SIDE_EFFECTS_ON_IMPORT, | ||
| 'react-fetch/node': HAS_NO_SIDE_EFFECTS_ON_IMPORT, | ||
| 'react-dom': HAS_NO_SIDE_EFFECTS_ON_IMPORT, |
Contributor
Author
There was a problem hiding this comment.
We have a block of code in ReactTestUtils that is wrapped in the feature flag. Inside this block we reference an import from react-dom. When we remove the block, we end up with having a dangling import to react-dom at the top of the module without it being used. In turn, this causes Rollup to fail the build.
This will organically go away when we remove the flags entirely from OSS.
trueadm
changed the title
linjiajian999
pushed a commit
to linjiajian999/react
that referenced
this pull request
Jun 16, 2020
* Remove synamic modern event system flag for FB
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes the modern event system flag enabled statically for FB bundles.