CI job to check that forks are in sync#20795
Merged
acdlite merged 1 commit intofacebook:masterfrom Feb 11, 2021
Merged
Conversation
facebook-github-bot
added
CLA Signed
React Core Team
acdlite
force-pushed
the
ci-check-sync-forks
branch
from
30d942f to
2b98224
Compare
|
Comparing: 9e9be6c...f7d9a5c Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
acdlite
force-pushed
the
ci-check-sync-forks
branch
from
acd23b4 to
831543b
Compare
rickhanlonii
approved these changes
Feb 10, 2021
| steps: | ||
| - checkout | ||
| - run: yarn workspaces info | head -n -1 > workspace_info.txt | ||
| - *restore_node_modules |
Member
There was a problem hiding this comment.
If we got rid of glob and minimalist in the replace-fork script, we could skip these two steps to restore node_modules.
Collaborator
Author
There was a problem hiding this comment.
Would stamp that PR
We don't always keep the reconciler forks in sync (otherwise it we wouldn't have forked it) but during periods when they are meant to be in sync, we use this job to confirm there are no differences.
acdlite
force-pushed
the
ci-check-sync-forks
branch
from
539a6fb to
f7d9a5c
Compare
koto
pushed a commit
to koto/react
that referenced
this pull request
Jun 15, 2021
We don't always keep the reconciler forks in sync (otherwise it we wouldn't have forked it) but during periods when they are meant to be in sync, we use this job to confirm there are no differences.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We don't always keep the reconciler forks in sync (otherwise it we wouldn't have forked it) but during periods when they are meant to be in sync, we use this job to confirm there are no differences.