Skip to content

[CI] Publish to release channels sequentially#20827

Merged
acdlite merged 1 commit intofacebook:masterfrom
acdlite:ci-publish-sequentially
Feb 16, 2021
Merged

[CI] Publish to release channels sequentially#20827
acdlite merged 1 commit intofacebook:masterfrom
acdlite:ci-publish-sequentially

Conversation

@acdlite
Copy link
Copy Markdown
Collaborator

@acdlite acdlite commented Feb 16, 2021

npm will sometimes fail if you try to concurrently publish two different versions of the same package, even if they use different dist tags.

So instead of publishing to the Next and Experimental channels simultaneously, we'll do them one after the other.

If we did want to speed up these publish workflows, we could parallelize by package instead of by release channel.

npm will sometimes fail if you try to concurrently publish two different
versions of the same package, even if they use different dist tags.

So instead of publishing to the Next and Experimental channels
simultaneously, we'll do them one after the other.

If we did want to speed up these publish workflows, we could paralellize
by package instead of by release channel.
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Feb 16, 2021
@sizebot
Copy link
Copy Markdown

sizebot commented Feb 16, 2021

Comparing: 1a74726...2429f74

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 122.34 kB 122.34 kB = 39.40 kB 39.40 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 128.92 kB 128.92 kB = 41.46 kB 41.46 kB
facebook-www/ReactDOM-prod.classic.js = 404.69 kB 404.69 kB = 75.17 kB 75.17 kB
facebook-www/ReactDOM-prod.modern.js = 393.04 kB 393.04 kB = 73.27 kB 73.27 kB
facebook-www/ReactDOMForked-prod.classic.js = 404.70 kB 404.70 kB = 75.17 kB 75.17 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 2429f74

@acdlite acdlite merged commit 6f88438 into facebook:master Feb 16, 2021
koto pushed a commit to koto/react that referenced this pull request Jun 15, 2021
npm will sometimes fail if you try to concurrently publish two different
versions of the same package, even if they use different dist tags.

So instead of publishing to the Next and Experimental channels
simultaneously, we'll do them one after the other.

If we did want to speed up these publish workflows, we could paralellize
by package instead of by release channel.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants