Added Separate DevTools Feature Flags for react-devtools-core#22199
Merged
lunaruan merged 1 commit intofacebook:mainfrom Aug 30, 2021
Merged
Added Separate DevTools Feature Flags for react-devtools-core#22199lunaruan merged 1 commit intofacebook:mainfrom
lunaruan merged 1 commit intofacebook:mainfrom
Conversation
facebook-github-bot
added
CLA Signed
React Core Team
bvaughn
reviewed
Aug 30, 2021
Contributor
bvaughn
left a comment
bvaughn
left a comment
There was a problem hiding this comment.
This looks good! Couple of small requested changes.
lunaruan
force-pushed
the
add_react_native_feature_flags
branch
from
4420c18 to
5eddfe4
Compare
bvaughn
approved these changes
Aug 30, 2021
zhengjitf
pushed a commit
to zhengjitf/react
that referenced
this pull request
Apr 15, 2022
lunaruan commented 3 days ago • This PR adds separate DevTools feature flag configurations for react-devtools-core. It also breaks the builds down into facebook specific and open source flags so we can experiment in React Native. Tested yarn build:standalone, yarn build:backend, yarn build:standalone:fb, and yarn build:backend:fb and inspected the output to make sure each package used the correct feature flags (the first two use core-oss and the latter two use fb-oss.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds separate DevTools feature flag configurations for
react-devtools-core. It also breaks the builds down into facebook specific and open source flags so we can experiment in React Native.Tested
yarn build:standalone,yarn build:backend,yarn build:standalone:crx, andyarn build:backend:crxand inspected the output to make sure each package used the correct feature flags (the first two usecore-ossand the latter two usefb-oss.