Skip to content

Move lint job to new, combined CI workflow#22386

Merged
acdlite merged 2 commits intofacebook:mainfrom
acdlite:migrate-ci-lint
Sep 21, 2021
Merged

Move lint job to new, combined CI workflow#22386
acdlite merged 2 commits intofacebook:mainfrom
acdlite:migrate-ci-lint

Conversation

@acdlite
Copy link
Copy Markdown
Collaborator

@acdlite acdlite commented Sep 21, 2021

Moves the lint job our new, combined CI workflow.

After this, there is only one job remaining to be migrated. Then we can delete the old workflow and build script.

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Sep 21, 2021
@sizebot
Copy link
Copy Markdown

sizebot commented Sep 21, 2021

Comparing: fc57432...60b46f0

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 127.39 kB 127.39 kB = 40.59 kB 40.59 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 130.21 kB 130.21 kB = 41.51 kB 41.51 kB
facebook-www/ReactDOM-prod.classic.js = 405.44 kB 405.44 kB = 75.05 kB 75.05 kB
facebook-www/ReactDOM-prod.modern.js = 394.03 kB 394.03 kB = 73.34 kB 73.34 kB
facebook-www/ReactDOMForked-prod.classic.js = 405.44 kB 405.44 kB = 75.05 kB 75.05 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 60b46f0

Moves the lint job our new, combined CI workflow.

After this, there is only one job remaining to be migrated. Then we
can delete the old workflow and build script.
This workflow is now empty so we can remove it
@acdlite acdlite marked this pull request as ready for review September 21, 2021 15:02
@acdlite acdlite merged commit 7c60496 into facebook:main Sep 21, 2021
zhengjitf pushed a commit to zhengjitf/react that referenced this pull request Apr 15, 2022
* Move lint job to new, combined CI workflow

Moves the lint job our new, combined CI workflow.

After this, there is only one job remaining to be migrated. Then we
can delete the old workflow and build script.

* Remove "stable" CI workflow

This workflow is now empty so we can remove it
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants