Test showing that a mismatch at the root recovers with client render but shows loading state#22873
Merged
salazarm merged 4 commits intofacebook:mainfrom Dec 6, 2021
Merged
Conversation
facebook-github-bot
added
CLA Signed
React Core Team
salazarm
force-pushed
the
rootRecoverWithClientRender
branch
from
d95921a to
74719ff
Compare
salazarm
force-pushed
the
rootRecoverWithClientRender
branch
from
74719ff to
f9c7a15
Compare
|
Comparing: 4729ff6...a37fe94 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
salazarm
changed the title
salazarm
force-pushed
the
rootRecoverWithClientRender
branch
from
11b1f87 to
a37fe94
Compare
zhengjitf
pushed a commit
to zhengjitf/react
that referenced
this pull request
Apr 15, 2022
…but shows loading state (facebook#22873) * rm console.log * gate test * move test * show fallback state
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
As titled
How did you test this change?
This is a test