Delete __SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED from React Native Renderer#31276
Merged
Conversation
…t Native Renderer
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
kassens
approved these changes
Oct 16, 2024
|
Comparing: 77b637d61200eef4dca4cbe4258da358d6337c7b...7e823db2e4fe6dac62c3a10098c031ce07a9ac2f Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
github-actions Bot
pushed a commit
that referenced
this pull request
Oct 16, 2024
…t Native Renderer (#31276) ## Summary The React Native Renderer exports a `__SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED` property with a single method that has no remaining call sites: `computeComponentStackForErrorReporting` This PR cleans up this unused export. ## How did you test this change? ``` $ yarn $ yarn flow fabric $ yarn test ``` DiffTrain build for [a3d9ea0](a3d9ea0)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The React Native Renderer exports a
__SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIREDproperty with a single method that has no remaining call sites:computeComponentStackForErrorReportingThis PR cleans up this unused export.
How did you test this change?