chore: remove unsued deps from React Compiler Babel plugin#31315
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
|
Oh thank you! |
This was referenced Oct 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Since the Babel plugin is bundled into a single file (except for
@babel/typesreact/compiler/packages/babel-plugin-react-compiler/rollup.config.js
Line 18 in 45804af
devDependencies.Main motivation is e.g. not installing ancient version of
pretty-format(asked in #29062 without getting a reason, but if consumers can just skip the deps entirely that's even better).How did you test this change?
I tested by installing the plugin into an empty project, deleting everything in
node_modulesexcept forbabel-plugin-react-compilerand doingrequire('babel-plugin-react-compiler'). It still worked fine, so it should work in other cases as well 😀