Skip to content

chore: remove unsued deps from React Compiler Babel plugin#31315

Merged
poteto merged 1 commit into
facebook:mainfrom
SimenB:remove-babel-compiler-deps
Oct 22, 2024
Merged

chore: remove unsued deps from React Compiler Babel plugin#31315
poteto merged 1 commit into
facebook:mainfrom
SimenB:remove-babel-compiler-deps

Conversation

@SimenB
Copy link
Copy Markdown
Contributor

@SimenB SimenB commented Oct 22, 2024

Summary

Since the Babel plugin is bundled into a single file (except for @babel/types

const NO_INLINE = new Set(['@babel/types']);
) we can move these deps to devDependencies.

Main motivation is e.g. not installing ancient version of pretty-format (asked in #29062 without getting a reason, but if consumers can just skip the deps entirely that's even better).

How did you test this change?

I tested by installing the plugin into an empty project, deleting everything in node_modules except for babel-plugin-react-compiler and doing require('babel-plugin-react-compiler'). It still worked fine, so it should work in other cases as well 😀

@vercel
Copy link
Copy Markdown

vercel Bot commented Oct 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 22, 2024 0:11am

@poteto
Copy link
Copy Markdown
Contributor

poteto commented Oct 22, 2024

Oh thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants