Skip to content

Capture the source and not just the stack on first seen error#31367

Merged
sebmarkbage merged 1 commit into
facebook:mainfrom
sebmarkbage:rethrowownerstacks
Oct 28, 2024
Merged

Capture the source and not just the stack on first seen error#31367
sebmarkbage merged 1 commit into
facebook:mainfrom
sebmarkbage:rethrowownerstacks

Conversation

@sebmarkbage
Copy link
Copy Markdown
Contributor

Otherwise we can't capture the owner stack at the right location when there's a rethrow.

Otherwise we can't capture the owner stack at the right location.
@sebmarkbage sebmarkbage requested review from eps1lon and gnoff October 27, 2024 00:03
@vercel
Copy link
Copy Markdown

vercel Bot commented Oct 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 27, 2024 0:06am

@react-sizebot
Copy link
Copy Markdown

The size diff is too large to display in a single comment. The GitHub action for this pull request contains an artifact called 'sizebot-message.md' with the full message.

Generated by 🚫 dangerJS against 6caeb3a

@sebmarkbage sebmarkbage merged commit 0bc3074 into facebook:main Oct 28, 2024
github-actions Bot pushed a commit that referenced this pull request Oct 28, 2024
Otherwise we can't capture the owner stack at the right location when
there's a rethrow.

DiffTrain build for [0bc3074](0bc3074)
github-actions Bot pushed a commit that referenced this pull request Oct 28, 2024
Otherwise we can't capture the owner stack at the right location when
there's a rethrow.

DiffTrain build for [0bc3074](0bc3074)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants