Conversation
Rather than notify on every label event on a PR by a core team member, only do so for the specific core team label event.
github-actions
Bot
added
the
React Core Team
|
Comparing: 10a4c88f58233074f293ab387b73e96b67192538...1d1b5db3ce6841e5e86cd60d89edabfeaaabb188 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
rickhanlonii
reviewed
Feb 3, 2025
|
|
||
| notify: | ||
| if: ${{ needs.check_maintainer.outputs.is_core_team == 'true' }} | ||
| if: ${{ needs.check_maintainer.outputs.is_core_team == 'true' && github.event.label.name == 'React Core Team' }} |
Member
There was a problem hiding this comment.
What about instead of using the label, we used the PR created event?
on:
pull_request_target:
types: [opened]
paths-ignore:the only reason I used the label before is that we didn't have the core team info in the repo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rather than notify on every label event on a PR by a core team member, only do so for the specific core team label event.