Log errors from startViewTransition to onRecoverableError#32540
Conversation
github-actions
Bot
added
the
React Core Team
|
Comparing: 99e1024051f2e6b2d2849b966e2f4354aef2a1d0...16c46fa802e407157ed3a45fd9d4ab17b02aceed Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
| pendingTransitionTypes, | ||
| flushGestureMutations, | ||
| flushGestureAnimations, | ||
| reportViewTransitionError, |
There was a problem hiding this comment.
Does it make sense to run this in the context of finishedWork or is that not a relevant Owner of a potential error?
There was a problem hiding this comment.
finishedWork is just the HostRoot so it has no owner at all.
In general these errors has no owner at all. There are other warnings we can add earlier to prevent some of these errors from happening in the first place. For example, we should have a warning when two ViewTransition components are mounted with the same name. Even if they don't happen to be part of the current transition and those could have owners.
| 'This can happen if a Navigation is blocked on React itself. ' + | ||
| "Such as if it's resolved inside useEffect. " + | ||
| 'This can be solved by moving the resolution to useLayoutEffect.', |
There was a problem hiding this comment.
I'm not following this one. Any chance we can manually trigger this scenario in the fixture?
There was a problem hiding this comment.
If this switches to useEffect instead of useLayoutEffect it should trigger it.
https://github.com/facebook/react/blob/main/fixtures/view-transition/src/components/App.js#L84-L86
Since the navigation should be blocked by the commit and the navigation blocks the commit from preceding the timing of unblocking the navigation needs to be in useLayoutEffect.
…2540) We customize the messages only in DEV to keep it small in prod. We skip some messages that are not really errors but more like information.
[diff facebook/react@0ca3deeb...6aa8254b](facebook/react@0ca3dee...6aa8254) <details> <summary>React upstream changes</summary> - facebook/react#32465 - facebook/react#32540 - facebook/react#32565 </details>
Follow up to #32540. We do allow gestures to be cancelled early (we call skipTransition) if the gesture stops before it has even started. This happens in the fixture when we auto-scroll.
5 participants
We customize the messages only in DEV to keep it small in prod.
We skip some messages that are not really errors but more like information.