Don't skip content in visible offscreen trees for View Transitions#35063
Merged
Conversation
Also, don't not skip hidden trees.
github-actions
Bot
added
the
React Core Team
|
Comparing: 5a2205b...6ae9c92 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
github-actions Bot
pushed a commit
that referenced
this pull request
Nov 6, 2025
…35063) Also, don't not skip hidden trees. Memoized state is null when an Offscreen boundary (Suspense or Activity) is visible. This logic was inversed in a couple of View Transition checks which caused pairs to be discovered or not discovered incorrectly for insertion and deletion of Suspense or Activity boundaries. DiffTrain build for [37b089a](37b089a)
github-actions Bot
pushed a commit
to code/lib-react
that referenced
this pull request
Nov 9, 2025
…tions (facebook#35066) Follow up to facebook#35063. I forgot there's another variant of this in the ApplyGesture path. DiffTrain build for [38bdda1](facebook@38bdda1)
github-actions Bot
pushed a commit
to code/lib-react
that referenced
this pull request
Nov 9, 2025
…tions (facebook#35066) Follow up to facebook#35063. I forgot there's another variant of this in the ApplyGesture path. DiffTrain build for [38bdda1](facebook@38bdda1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also, don't not skip hidden trees.
Memoized state is null when an Offscreen boundary (Suspense or Activity) is visible.
This logic was inversed in a couple of View Transition checks which caused pairs to be discovered or not discovered incorrectly for insertion and deletion of Suspense or Activity boundaries.