Skip to content

Conversation

@eps1lon
Copy link
Collaborator

@eps1lon eps1lon commented Nov 10, 2025

Stacked on #35093

List is not visible if no named Activities exist.

Will include the same list in the Components tab.

CleanShot.2025-11-10.at.08.56.30.mp4

@meta-cla meta-cla bot added the CLA Signed label Nov 10, 2025
@github-actions github-actions bot added the React Core Team Opened by a member of the React Core Team label Nov 10, 2025
@eps1lon eps1lon marked this pull request as ready for review November 10, 2025 08:17
@eps1lon eps1lon force-pushed the sebbie/11-07-_activity_activity_list branch from 819094c to a782ec9 Compare November 11, 2025 10:15
<React.Activity name="/outer/" mode="visible">
<React.Activity name="outer/" mode="visible">
<OuterSegment>
<React.Activity name="/outer/inner" mode="visible">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that the way next.js uses these, the previous path is not in the second path. Which is part of the reason indent is important. You can't assume the name is a path.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In fact, I'd probably not use paths as the examples to avoid next-isms being assumed.

@sebmarkbage
Copy link
Collaborator

I think the "show all" should be more like "All" or something rather than a back button. It's not switching modes of any UI so much as it's just another menu item.

@sebmarkbage
Copy link
Collaborator

Can we get one for the Components panel too?

@eps1lon
Copy link
Collaborator Author

eps1lon commented Nov 18, 2025

Can we get one for the Components panel too?

Was planned as a follow-up. Wanted to get sign-off for the design first before I add it to Components tab since I basically have to copy Suspense tab layout over.

@eps1lon eps1lon force-pushed the sebbie/11-07-_activity_activity_list branch from a782ec9 to ebb376d Compare November 18, 2025 08:28
@eps1lon eps1lon merged commit 7f1a085 into facebook:main Nov 18, 2025
237 of 238 checks passed
@eps1lon eps1lon deleted the sebbie/11-07-_activity_activity_list branch November 18, 2025 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants