[DevTools] hotkey to start/stop profiling#35160
Merged
emily8rown merged 21 commits intoNov 21, 2025
Merged
Conversation
vzaidman
reviewed
Nov 17, 2025
vzaidman
reviewed
Nov 17, 2025
vzaidman
reviewed
Nov 17, 2025
hoxyq
reviewed
Nov 17, 2025
hoxyq
approved these changes
Nov 19, 2025
hoxyq
reviewed
Nov 21, 2025
Comment on lines
+679
to
+682
| } finally { | ||
| // Restore fake timers for other tests | ||
| jest.useFakeTimers(); | ||
| } |
Contributor
Author
There was a problem hiding this comment.
Technically no because in the setupTest file the before each sets it to use fake timers. I guess the argument would be not being dependent on if that changes?
Contributor
There was a problem hiding this comment.
You probably don't need fake timers here, because there is no logic that is tied to timers: intervals, timeouts, etc.
So if it passes with these lines removed, just remove it. If not, lets investigate why this is required.
Contributor
Author
There was a problem hiding this comment.
before when I used fake timers I was getting a time out after 5 seconds from the recursivelyflush in utils act and actAsync but this may just be because the profiler and its contexts have a lot of timers/ are more complex?
Contributor
Author
There was a problem hiding this comment.
I've got it to now use the fake timers and have turned recursively flush off to avoid the timeout
|
|
||
| try { | ||
| // Render the profiler - use React.act to ensure render completes | ||
| React.act(() => { |
Contributor
There was a problem hiding this comment.
Can you use utils.actAsync here? This should also allow removing the Promise on line 632.
|
|
||
| // Dispatch keyboard event to toggle profiling on | ||
| ownerWindow.dispatchEvent(keyEvent); | ||
| await waitForProfilingState(true); |
Contributor
There was a problem hiding this comment.
Does it have to be async, though? Does it fail if you check it synchronously?
If it fails, can you try emitting the event as part of act or actAsync?
utils.act(() => ownerWindow.dispatchEvent(keyEvent));
Co-authored-by: Ruslan Lesiutin <28902667+hoxyq@users.noreply.github.com>
…8rown/react into devtools-profiling-hot-key
github-actions Bot
pushed a commit
that referenced
this pull request
Nov 21, 2025
## Summary The built-in browser profiler supports starting/stopping with Cmd+E. For Symmetry this adds the same hotkey for react devtools profiler. ## How did you test this change? yarn build:\<browser name\> yarn run test:\<browser name\> <img width="483" height="135" alt="Screenshot 2025-11-17 at 14 30 34" src="https://github.com/user-attachments/assets/426939aa-15da-4c21-87a4-e949e6949482" /> firefox: https://github.com/user-attachments/assets/6f225b90-828f-4e79-a364-59d6bc942f83 edge: https://github.com/user-attachments/assets/5b2e9242-f0e8-481b-99a2-2dd78099f3ac chrome: https://github.com/user-attachments/assets/790aab02-2867-4499-aec1-e32e38c763f9 --------- Co-authored-by: Ruslan Lesiutin <28902667+hoxyq@users.noreply.github.com> DiffTrain build for [fd524fe](fd524fe)
github-actions Bot
pushed a commit
that referenced
this pull request
Nov 21, 2025
## Summary The built-in browser profiler supports starting/stopping with Cmd+E. For Symmetry this adds the same hotkey for react devtools profiler. ## How did you test this change? yarn build:\<browser name\> yarn run test:\<browser name\> <img width="483" height="135" alt="Screenshot 2025-11-17 at 14 30 34" src="https://github.com/user-attachments/assets/426939aa-15da-4c21-87a4-e949e6949482" /> firefox: https://github.com/user-attachments/assets/6f225b90-828f-4e79-a364-59d6bc942f83 edge: https://github.com/user-attachments/assets/5b2e9242-f0e8-481b-99a2-2dd78099f3ac chrome: https://github.com/user-attachments/assets/790aab02-2867-4499-aec1-e32e38c763f9 --------- Co-authored-by: Ruslan Lesiutin <28902667+hoxyq@users.noreply.github.com> DiffTrain build for [fd524fe](fd524fe)
github-actions Bot
pushed a commit
to code/lib-react
that referenced
this pull request
Nov 23, 2025
## Summary The built-in browser profiler supports starting/stopping with Cmd+E. For Symmetry this adds the same hotkey for react devtools profiler. ## How did you test this change? yarn build:\<browser name\> yarn run test:\<browser name\> <img width="483" height="135" alt="Screenshot 2025-11-17 at 14 30 34" src="https://github.com/user-attachments/assets/426939aa-15da-4c21-87a4-e949e6949482" /> firefox: https://github.com/user-attachments/assets/6f225b90-828f-4e79-a364-59d6bc942f83 edge: https://github.com/user-attachments/assets/5b2e9242-f0e8-481b-99a2-2dd78099f3ac chrome: https://github.com/user-attachments/assets/790aab02-2867-4499-aec1-e32e38c763f9 --------- Co-authored-by: Ruslan Lesiutin <28902667+hoxyq@users.noreply.github.com> DiffTrain build for [fd524fe](facebook@fd524fe)
github-actions Bot
pushed a commit
to code/lib-react
that referenced
this pull request
Nov 23, 2025
## Summary The built-in browser profiler supports starting/stopping with Cmd+E. For Symmetry this adds the same hotkey for react devtools profiler. ## How did you test this change? yarn build:\<browser name\> yarn run test:\<browser name\> <img width="483" height="135" alt="Screenshot 2025-11-17 at 14 30 34" src="https://github.com/user-attachments/assets/426939aa-15da-4c21-87a4-e949e6949482" /> firefox: https://github.com/user-attachments/assets/6f225b90-828f-4e79-a364-59d6bc942f83 edge: https://github.com/user-attachments/assets/5b2e9242-f0e8-481b-99a2-2dd78099f3ac chrome: https://github.com/user-attachments/assets/790aab02-2867-4499-aec1-e32e38c763f9 --------- Co-authored-by: Ruslan Lesiutin <28902667+hoxyq@users.noreply.github.com> DiffTrain build for [fd524fe](facebook@fd524fe)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The built-in browser profiler supports starting/stopping with Cmd+E. For Symmetry this adds the same hotkey for react devtools profiler.
How did you test this change?
yarn build:<browser name>
yarn run test:<browser name>
firefox:
https://github.com/user-attachments/assets/6f225b90-828f-4e79-a364-59d6bc942f83
edge:
https://github.com/user-attachments/assets/5b2e9242-f0e8-481b-99a2-2dd78099f3ac
chrome:
https://github.com/user-attachments/assets/790aab02-2867-4499-aec1-e32e38c763f9