Add key warning to nested collections#3758
Merged
sophiebits merged 1 commit intofacebook:masterfrom Apr 27, 2015
Merged
Conversation
Also when reusing elements in multiple contexts -- before we were mutating each element to indicate its validity; now we mutate the array containing it (which we create, in the case of rest-arg children). Fixes facebook#2496. Fixes facebook#3348.
sophiebits
force-pushed
the
keys-keys-keys
branch
from
bc76ef9 to
0866367
Compare
sophiebits
added a commit
that referenced
this pull request
Apr 27, 2015
Add key warning to nested collections
zpao
added a commit
to zpao/react
that referenced
this pull request
May 7, 2015
zpao
added a commit
to zpao/react
that referenced
this pull request
May 8, 2015
zpao
added a commit
that referenced
this pull request
May 8, 2015
Followup to #3758 so we actually test things
framp
pushed a commit
to framp/react
that referenced
this pull request
May 26, 2015
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also when reusing elements in multiple contexts -- before we were mutating each element to indicate its validity; now we mutate the array containing it (which we create, in the case of rest-arg children).
Fixes #2496. Fixes #3348.