Merged
Conversation
| @@ -198,16 +198,10 @@ describe('ReactDOMComponent', function() { | |||
| ReactDOM.render(<span style={style}></span>, div); | |||
Collaborator
There was a problem hiding this comment.
Might as well change the test title to skip semi 😄
Member
Author
There was a problem hiding this comment.
Good call. Want to accept too? :D
Contributor
|
@zpao updated the pull request. |
Contributor
|
👍 How did the mutation warning go away? |
Member
Author
|
shallowEqual now uses Object.is to compare values. We use shallowEqual in our style mutation detection. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This just makes sure we're on the latest. This does come with a change that needs to be called out - that shallowCompare now treats NaN as the same value, and some other tiny equality related changes. This is because fbjs now uses Object.is to compare values. We talked about this a bit in #5773. The result here is that our "mutated style" warning will have fewer false positives and specifically will no longer warn for the NaN case (thus the updated test).