[website] Fix jump on the header#6312
Merged
zpao merged 1 commit intofacebook:masterfrom Mar 21, 2016
Merged
Conversation
Algolia adds two inline styles ```css position: relative; vertical-align: top; ``` to the element once the script inserted at the end of the page runs which super slightly moves the header. The fix is to always apply those two rules this way it doesn't jump. I did not notice it on my machine because it doesn't move when custom fonts are not being used. Test Plan: - Open two tabs: reactjs.com and localhost:4000/react - Click around on reactjs.com to prime the cache with the fonts - Switch tabs and click around on localhost (but do not force refresh!) - Now you get custom fonts loaded locally and it doesn't jump when you change tabs
Contributor
Author
Member
|
I don't see the issue and fonts should be loading for localhost… But ok! |
Contributor
|
@vjeux updated the pull request. |
zpao
added
Component: Documentation & Website
and removed
GH Review: review-needed
labels
zpao
added a commit
that referenced
this pull request
Mar 21, 2016
[website] Fix jump on the header (cherry picked from commit 39ccdcc)
1999
pushed a commit
to 1999/react
that referenced
this pull request
Mar 30, 2016
* upstream-v0.14.8: (191 commits) v0.14.8 Update README and CHANGELOG for 0.14.8 Bump version of 0.14.8 dev Use babel 5 bin, not cached babel 6 cli [debug] log npm packages Merge pull request facebook#6312 from vjeux/fix_docs_jump Merge pull request facebook#6313 from jimfb/script-integrity-attribute Merge pull request facebook#6281 from rgarifullin/microfix_docs Merge pull request facebook#6260 from iawia002/master Merge pull request facebook#6258 from iamchenxin/zh_docs031316rest Merge pull request facebook#6256 from iamchenxin/zh_docs031316 Merge pull request facebook#6202 from vjeux/search Add v15 RC2 blog post Merge pull request facebook#6214 from koba04/patch-6 Merge pull request facebook#6208 from JinxiuLee/patch-2 Fix style= formatting in v15 rc blog post Merge pull request facebook#6207 from zpao/15rc-blog-post-corrections v15.0 rc1 blog post Merge pull request facebook#6180 from camjc/master Merge pull request facebook#6183 from jimfb/rec-update ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Algolia adds two inline styles
to the element once the script inserted at the end of the page runs which super slightly moves the header. The fix is to always apply those two rules this way it doesn't jump. I did not notice it on my machine because it doesn't move when custom fonts are not being used.
Test Plan: