[Docs] Switch to codemirror's JSX mode#6898
Merged
zpao merged 1 commit intofacebook:masterfrom May 27, 2016
Merged
Conversation
keyz
changed the title
ghost
added
Member
|
lgtm, thanks! |
zpao
added
Component: Documentation & Website
and removed
GH Review: review-needed
labels
zpao
pushed a commit
that referenced
this pull request
May 31, 2016
(cherry picked from commit c8bab76)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6894. I upgraded codemirror from
3.20.1to5.15.2and switched to their JSX mode. Also I tweaked the theme a little bit since there are some code highlighting differences between v3 and v5.This is a huge diff due to changing codemirror's source files, but the actual changes are just
docs/_css/_solarized.scss,docs/_js/live_editor.js, anddocs/_layouts/default.html.Before:
After:
