Fix ReactComponentTreeHook.getRegisteredIDs() to work with inlined components#7490
Merged
gaearon merged 1 commit intofacebook:masterfrom Aug 13, 2016
gaearon:fix-text-ids
Merged
Fix ReactComponentTreeHook.getRegisteredIDs() to work with inlined components#7490gaearon merged 1 commit intofacebook:masterfrom gaearon:fix-text-ids
gaearon merged 1 commit intofacebook:masterfrom
gaearon:fix-text-ids
Conversation
…ntent I broke this in #7463: parseInt() cuts off #text at the end. Changing to just use negative numbers instead.
ghost
added
gaearon
changed the title
Member
|
👍 |
Collaborator
|
I'd rather we shared the debug ID counter with instantiateReactComponent but this is all right as long as we remember that it's happening. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I broke this in #7463:
parseInt()cuts off#textat the end.Changing to just use negative numbers instead.