Remove keyMirror in ReactMultiChildUpdateTypes#7589
Merged
vjeux merged 1 commit intofacebook:masterfrom Aug 28, 2016
Merged
Conversation
vjeux
force-pushed
the
type_ReactMultiChildUpdateTypes
branch
from
067997f to
5e39931
Compare
ghost
added
Contributor
Author
|
Closing this for now, I have another proposal for dealing with keyMirror |
As mentioned in https://www.facebook.com/groups/2003630259862046/permalink/2097088000516271/ I'm going to kill this instance of keyMirror and use a plain string instead with a type union. The current type union is unused right now but when I type ReactMultiChild I will use it.
vjeux
force-pushed
the
type_ReactMultiChildUpdateTypes
branch
from
5e39931 to
d5f0076
Compare
Contributor
Author
|
Updated with the RFC plan I outlined in https://www.facebook.com/groups/2003630259862046/permalink/2097088000516271/ |
Contributor
Author
|
|
vjeux
changed the title
zpao
pushed a commit
that referenced
this pull request
Oct 4, 2016
As mentioned in https://www.facebook.com/groups/2003630259862046/permalink/2097088000516271/ I'm going to kill this instance of keyMirror and use a plain string instead with a type union. The current type union is unused right now but when I type ReactMultiChild I will use it. (cherry picked from commit c9e03f0)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As mentioned in https://www.facebook.com/groups/2003630259862046/permalink/2097088000516271/ I'm going to kill this instance of keyMirror and use a plain string instead with a type union.
The current type union is unused right now but when I type ReactMultiChild I will use it.