[Fiber] Schedule animation regardless of deferred work#8187
Merged
gaearon merged 2 commits intofacebook:masterfrom Nov 2, 2016
Merged
[Fiber] Schedule animation regardless of deferred work#8187gaearon merged 2 commits intofacebook:masterfrom
gaearon merged 2 commits intofacebook:masterfrom
Conversation
Collaborator
|
Lol I literally just made the same commit on my PR: b91b47f |
Collaborator
|
Sorry, not commit, I meant the |
Contributor
|
Seems good |
sebmarkbage
approved these changes
Nov 2, 2016
Contributor
|
You've stumbled upon one of @sebmarkbage's famous early optimizations. |
Collaborator
Author
|
Trust me it lints. |
acusti
pushed a commit
to brandcast/react
that referenced
this pull request
Mar 15, 2017
* Remove comments about implementation details * Schedule animation regardless of deferred work
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the behavior (and changes my remaining tests to test for the right thing).
Even if there's a deferred callback scheduled, we should still schedule animation callback.
I'd be happy to refactor this to functions like
ensureAnimatedCallbackScheduledor something if you care. For now just wrote it as inline ifs.