Correct a method param in Implementation Notes#8252
Merged
gaearon merged 1 commit intofacebook:masterfrom Nov 10, 2016
Merged
Conversation
Contributor
|
Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours has expired. Before we can review or merge your code, we need you to email cla@fb.com with your details so we can update your status. |
Contributor
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
gaearon
added
Component: Documentation & Website
and removed
GH Review: review-needed
labels
Collaborator
|
Thanks. |
Contributor
Author
|
Thanks for merging! |
tomocchino
pushed a commit
that referenced
this pull request
Nov 16, 2016
(cherry picked from commit fa4710f)
acusti
pushed a commit
to brandcast/react
that referenced
this pull request
Mar 15, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a tiny fix on Implementation Notes.
According to React.Component in the reference,
componentWillUpdate(nextProps, nextState)is the correct signature. Because the guide hasn't referred tostateat the point,componentWillUpdate(nextProps)would be correct here.