Revert temporary compatibility fixes for Devtool -> Hook#8256
Merged
gaearon merged 1 commit intofacebook:masterfrom Nov 10, 2016
Merged
Conversation
This reverts commit bba0d99.
gaearon
deleted the
keyanzhang-revert-temporary-compatibility-fix-for-hooks
branch
Contributor
|
Thanks! |
Contributor
|
This is still used in www. I'll need to patch it up to sync. |
Collaborator
Author
|
Yea, sorry! It's just in one place, right? I figured whoever does the sync would see the failed static build error and change the name. I can do it myself if you'd like although it seems easier to do during next sync. |
acusti
pushed a commit
to brandcast/react
that referenced
this pull request
Mar 15, 2017
This reverts commit bba0d99.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that RN has its own copy of the reconciler we don't even need these for compat.
Still, I'll tag this as breaking just in case.
This rebases #7393.