[Fiber] Fix rendering SVG into non-React SVG tree#8638
Merged
gaearon merged 4 commits intofacebook:masterfrom Jan 14, 2017
Merged
[Fiber] Fix rendering SVG into non-React SVG tree#8638gaearon merged 4 commits intofacebook:masterfrom
gaearon merged 4 commits intofacebook:masterfrom
Conversation
It is failing in Fiber.
It happens to pass in Fiber.
A tag alone is not enough to determine the tree namespace.
Collaborator
Author
|
For some reason one of the new tests is failing for Stack in innerHTML mode. |
Contributor
@gaearon looks like a If you run the ~same code using var jsdom = require('jsdom').jsdom
var outerSVGRoot = document.createElementNS('http://www.w3.org/2000/svg', 'svg');
var container = document.createElementNS('http://www.w3.org/2000/svg', 'foreignObject');
outerSVGRoot.appendChild(container);
var markup = '<div react-reactroot></div>';
container.innerHTML = markup;
console.log(container.firstChild.namespaceURI);
// 'http://www.w3.org/2000/svg' |
jsdom doesn't give HTML namespace to foreignObject.innerHTML children. This problem doesn't exist in the browsers. facebook#8638 (comment) We will skip this test in non-createElement mode considering that non-createElement mounting is effectively dead code now anyway.
Collaborator
Author
|
I think you're right. Just skipping this test now since it's dead code anyway. We only use non-createElement code path for server rendering, but server rendering doesn't have mounting. The innerHTML is only assigned in the mounting code path. |
sebmarkbage
approved these changes
Jan 14, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We used to determine the root tree namespace by the tag name alone in Fiber.
However this was broken for cases when we render an SVG tree into another SVG tree outside React.
This PR introduces a few new tests and fixes this by reading namespace from the root container, and using it in conjunction with the tag to determine child namespace.
Addresses https://github.com/facebook/react/pull/8586/files/414f1ec324bbce828c84900d66d202b5d776b6aa#r93161706.