Skip to content

fix misspellings in comments and tests#8946

Merged
aweary merged 3 commits intofacebook:masterfrom
seangransee:correct_typos
Feb 13, 2017
Merged

fix misspellings in comments and tests#8946
aweary merged 3 commits intofacebook:masterfrom
seangransee:correct_typos

Conversation

@seangransee
Copy link
Copy Markdown
Contributor

go get -u github.com/client9/misspell/cmd/misspell
misspell  -w -error -source=text .

Comment thread docs/js/react-dom.js
@@ -5950,7 +5950,7 @@ ReactDOMComponent.Mixin = {
} else if (props.is) {
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a built file for the current stable version, so it will get reverted the next time it's built.
Let's omit this file.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gaearon I reverted the change in this file.

@seangransee seangransee force-pushed the correct_typos branch 2 times, most recently from c269a97 to 7b9f8ea Compare February 7, 2017 16:42
Copy link
Copy Markdown
Contributor

@aweary aweary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you 🎉

@aweary aweary merged commit c16ec5d into facebook:master Feb 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants