Skip to content

Conversation

@zpao
Copy link
Member

@zpao zpao commented Feb 7, 2014

cc @petehunt, @spicyj, @andreypopp, @syranide, anybody else using React in the real world who might want to argue against removing React from react-tools

@syranide
Copy link
Contributor

syranide commented Feb 7, 2014

@zpao I've only been "experimenting" so far and I'm honestly not sure what react-tools is, so I have no opinion. :)

@andreypopp
Copy link
Contributor

@zpao remove it!

zpao added 2 commits February 7, 2014 13:59
All of this is provided by the react package now, so there's no point in having
it available in multiple places. We *may* go back on that in the future for
shipping test utils, but for the time being, this is better for all.
zpao added a commit that referenced this pull request Feb 7, 2014
@zpao zpao merged commit 141f3a8 into facebook:master Feb 7, 2014
@benjamn
Copy link
Contributor

benjamn commented Feb 7, 2014

Eh, here's a use case for require("react-tools").React: https://github.com/benjamn/react-meteor/blob/master/src/require-react.js

@zpao
Copy link
Member Author

zpao commented Feb 7, 2014

@benjamn That's the easiest to fix: React = Npm.require('react'). I was more concerned with cases where people were accessing something like require('react-tools/build/modules/*')

@zpao zpao deleted the react-tools-revamp branch April 16, 2015 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants