Update attribute table for master #13421
Merged
+52
−52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nhunzaker
force-pushed
the
nh-update-attribute-table
branch
from
0795acd to
5a4d34d
Compare
nhunzaker
commented
Aug 16, 2018
| | `value=(symbol)`| (changed, error, warning, ssr error)| `` | | ||
| | `value=(function)`| (changed, warning, ssr warning)| `"function f() {}"` | | ||
| | `value=(symbol)`| (initial, warning, ssr error, ssr mismatch)| `<empty string>` | | ||
| | `value=(function)`| (initial, warning, ssr mismatch)| `<empty string>` | |
There was a problem hiding this comment.
These are fixed in #13394
gaearon
approved these changes
Aug 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the attribute table with the latest behavior on master. Working on fixes for symbols and functions, I noticed that a lot of boolean attributes correctly warn now, where they didn't on React stable.
I want to merge an updated table so that it's easier to determine the effects of my changes in #13394