Improve test harness of submit events #13463
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I found a test that was written more than 5 years ago and probably never run until now. The behavior still works, although the API changed quite a bit over the years. Seems like this was part of the initial public release already: facebook@75897c2#diff-1bf5126edab96f3b7fea034cd3b0c742R31
For more information, see facebook#13462
philipp-spiess
commented
Aug 22, 2018
| // This is a special case for submit and reset events as they are listened on | ||
| // at the element level and not the document. | ||
| // @see https://github.com/facebook/react/pull/13462 | ||
| it('should not receive submit events if native, interim DOM handler prevents it', () => { |
Contributor
Author
There was a problem hiding this comment.
This test indeed fails if I re-apply my changes from #13358. If the onSubmit handler added a preventDefault(), this would never be called.
nhunzaker
reviewed
Aug 22, 2018
|
|
||
| formRef.current.dispatchEvent( | ||
| new Event('reset', { | ||
| // https://developer.mozilla.org/en-US/docs/Web/Events/reset |
nhunzaker
approved these changes
Aug 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes a test that I've enabled in #13358 and another test that we've discussed in #13462 as well as some random cleanup while I'm at it.