-
Notifications
You must be signed in to change notification settings - Fork 49.9k
Also list <form> in error message as possible culprit #1770
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I like this, but please run the test before committing, this is failing (we check the error message). |
|
Note that this same error message is hardcoded in another place – can you update both? |
src/browser/ui/ReactMount.js
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(nit: do you mind adding a comma after <p>?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one more tiny nit: can you move the space between "parent." and "Try" to the previous line for consistency with the other line breaks?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@spicyj If I move the space, It would go exatly 1 character over the line limit (80chars),
so it would add another line…
Edit: doesn't really matter because the extra comma already means 1 more line is needed.
|
Thanks for the feedback, it would not have occured to me to run test for a wording change, but of course it makes sense :) |
|
Oh yea, I missed that - good find. Let's update both places. |
|
@zpao Cool, I updated it. |
Also list <form> in error message as possible culprit
|
Sorry for the delay! Thanks! |
very small change, but once you start listing things that can't be nested
<form>should be among them ;)