Skip to content

Some help little fixes ... remember "Right Resource Management" #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Some help little fixes ... remember "Right Resource Management" #18

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9d7b384
Added vars and code to "destroy" setInterval in componentWillMount
lguzzon May 30, 2013
db661b7
Fixing typo error ... componentWillUnmount
lguzzon May 30, 2013
7e39ad9
Little fixtures: Markdown code brackets, inner variable optimization
lguzzon May 30, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 18 additions & 6 deletions docs/docs/tutorial.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -394,7 +394,7 @@ var CommentBox = React.createClass({

The key is the call to `this.setState()`. We replace the old array of comments with the new one from the server and the UI automatically updates itself. Because of this reactivity, it is trivial to add live updates. We will use simple polling here but you could easily use WebSockets or other technologies.

```javascript{3,17-21,35}
```javascript{3,17-21,38}
// tutorial14.js
var CommentBox = React.createClass({
loadCommentsFromServer: function() {
Expand All @@ -412,11 +412,14 @@ var CommentBox = React.createClass({
},
componentWillMount: function() {
this.loadCommentsFromServer();
setInterval(
this.intervalID = setInterval(
this.loadCommentsFromServer.bind(this),
this.props.pollInterval
);
},
componentWillUnmount: function() {
clearInterval(this.intervalID);
},
render: function() {
return (
<div class="commentBox">
Expand Down Expand Up @@ -501,7 +504,7 @@ When a user submits a comment, we will need to refresh the list of comments to i

We need to pass data from the child component to its parent. We do this by passing a `callback` in props from parent to child:

```javascript{13-15,30}
```javascript{13-15,33}
// tutorial17.js
var CommentBox = React.createClass({
loadCommentsFromServer: function() {
Expand All @@ -522,11 +525,14 @@ var CommentBox = React.createClass({
},
componentWillMount: function() {
this.loadCommentsFromServer();
setInterval(
this.intervalID = setInterval(
this.loadCommentsFromServer.bind(this),
this.props.pollInterval
);
},
componentWillUnmount: function() {
clearInterval(this.intervalID);
},
render: function() {
return (
<div class="commentBox">
Expand Down Expand Up @@ -599,11 +605,14 @@ var CommentBox = React.createClass({
},
componentWillMount: function() {
this.loadCommentsFromServer();
setInterval(
this.intervalID = setInterval(
this.loadCommentsFromServer.bind(this),
this.props.pollInterval
);
},
componentWillUnmount: function() {
clearInterval(this.intervalID);
},
render: function() {
return (
<div class="commentBox">
Expand Down Expand Up @@ -654,11 +663,14 @@ var CommentBox = React.createClass({
},
componentWillMount: function() {
this.loadCommentsFromServer();
setInterval(
this.intervalID = setInterval(
this.loadCommentsFromServer.bind(this),
this.props.pollInterval
);
},
componentWillUnmount: function() {
clearInterval(this.intervalID);
},
render: function() {
return (
<div class="commentBox">
Expand Down