Skip to content

Run more flags in VARIANT tests #18461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 2, 2020
Merged

Run more flags in VARIANT tests #18461

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
59adaec
Run more flags in VARIANT tests
gaearon Apr 2, 2020
2f8d0c3
Revert enabling modern system
gaearon Apr 2, 2020
325ed34
Merge branch 'master' into vvv
gaearon Apr 2, 2020
e46e3fe
Fix
gaearon Apr 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions packages/react-interactions/events/src/dom/__tests__/Input-test.internal.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,8 +140,15 @@ describe('Input event responder', () => {
ref.current.dispatchEvent(
new Event('input', {bubbles: true, cancelable: true}),
);
expect(onChangeCalled).toBe(0);
expect(onValueChangeCalled).toBe(0);

if (ReactFeatureFlags.disableInputAttributeSyncing) {
// TODO: figure out why. This might be a bug.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't new. Copypaste from ChangeEventPlugin test from which this was copied.

expect(onChangeCalled).toBe(1);
expect(onValueChangeCalled).toBe(1);
} else {
expect(onChangeCalled).toBe(0);
expect(onValueChangeCalled).toBe(0);
}
});

it('should consider initial checkbox checked=true to be current', () => {
Expand Down
2 changes: 1 addition & 1 deletion packages/shared/forks/ReactFeatureFlags.www-dynamic.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@

export const warnAboutSpreadingKeyToJSX = __VARIANT__;
export const disableModulePatternComponents = __VARIANT__;
export const disableInputAttributeSyncing = __VARIANT__;

// These are already tested in both modes using the build type dimension,
// so we don't need to use __VARIANT__ to get extra coverage.
Expand All @@ -25,6 +26,5 @@ export const replayFailedUnitOfWorkWithInvokeGuardedCallback = __DEV__;
// Update the tests so that they pass in either mode, then set these
// to __VARIANT__.
export const enableTrustedTypesIntegration = false;
export const disableInputAttributeSyncing = false;
export const disableSchedulerTimeoutBasedOnReactExpirationTime = false;
export const enableModernEventSystem = false;