Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete useMutableSource implementation #22292

Merged
merged 1 commit into from
Sep 20, 2021

Conversation

acdlite
Copy link
Collaborator

@acdlite acdlite commented Sep 10, 2021

useMutableSource is being replaced with useSyncExternalStore.

Will wait to merge until after useSyncExternalStore is ready.

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Sep 10, 2021
@acdlite acdlite force-pushed the delete-usemutablesource branch 2 times, most recently from 4aa96a4 to ed015b0 Compare September 10, 2021 19:47
@sizebot
Copy link

sizebot commented Sep 10, 2021

Comparing: f50ff35...2bd76f8

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 129.49 kB 127.38 kB = 41.26 kB 40.58 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 132.31 kB 130.20 kB = 42.21 kB 41.50 kB
facebook-www/ReactDOM-prod.classic.js = 410.86 kB 405.21 kB = 76.01 kB 74.99 kB
facebook-www/ReactDOM-prod.modern.js = 399.43 kB 393.80 kB = 74.29 kB 73.28 kB
facebook-www/ReactDOMForked-prod.classic.js = 410.86 kB 405.21 kB = 76.01 kB 74.99 kB
oss-experimental/react-test-renderer/cjs/react-test-renderer.development.js = 627.74 kB 615.18 kB = 136.69 kB 133.92 kB
oss-experimental/react/umd/react.production.min.js = 11.82 kB 11.58 kB = 4.63 kB 4.57 kB
oss-experimental/react/umd/react.profiling.min.js = 11.82 kB 11.58 kB = 4.63 kB 4.57 kB
oss-stable-semver/react-test-renderer/umd/react-test-renderer.production.min.js = 79.65 kB 78.04 kB = 24.92 kB 24.41 kB
oss-stable/react-test-renderer/umd/react-test-renderer.production.min.js = 79.65 kB 78.04 kB = 24.92 kB 24.41 kB
oss-stable-semver/react-test-renderer/cjs/react-test-renderer.production.min.js = 79.44 kB 77.83 kB = 24.58 kB 24.07 kB
oss-stable/react-test-renderer/cjs/react-test-renderer.production.min.js = 79.44 kB 77.83 kB = 24.58 kB 24.07 kB
facebook-www/ReactTestRenderer-dev.modern.js = 634.10 kB 621.22 kB = 135.59 kB 132.75 kB
facebook-www/ReactTestRenderer-dev.classic.js = 634.09 kB 621.21 kB = 135.58 kB 132.74 kB
facebook-www/ReactART-dev.classic.js = 726.55 kB 711.79 kB = 154.78 kB 151.38 kB
oss-stable-semver/react-test-renderer/umd/react-test-renderer.development.js = 641.77 kB 628.66 kB = 134.77 kB 132.00 kB
oss-stable/react-test-renderer/umd/react-test-renderer.development.js = 641.77 kB 628.66 kB = 134.77 kB 132.00 kB
oss-stable-semver/react-test-renderer/cjs/react-test-renderer.development.js = 611.89 kB 599.33 kB = 133.34 kB 130.53 kB
oss-stable/react-test-renderer/cjs/react-test-renderer.development.js = 611.89 kB 599.33 kB = 133.34 kB 130.53 kB
facebook-www/ReactART-dev.modern.js = 716.27 kB 701.51 kB = 152.64 kB 149.25 kB
facebook-react-native/react-test-renderer/cjs/ReactTestRenderer-dev.js = 622.63 kB 609.78 kB = 134.36 kB 131.49 kB
oss-experimental/react-reconciler/cjs/react-reconciler.profiling.min.js = 101.93 kB 99.80 kB = 31.20 kB 30.53 kB
oss-stable-semver/react/umd/react.production.min.js = 11.18 kB 10.94 kB = 4.47 kB 4.40 kB
oss-stable/react/umd/react.production.min.js = 11.18 kB 10.94 kB = 4.47 kB 4.40 kB
oss-stable-semver/react/umd/react.profiling.min.js = 11.18 kB 10.94 kB = 4.47 kB 4.40 kB
oss-stable/react/umd/react.profiling.min.js = 11.18 kB 10.94 kB = 4.47 kB 4.40 kB
oss-experimental/react-art/cjs/react-art.development.js = 677.62 kB 663.25 kB = 146.49 kB 143.18 kB
oss-stable-semver/react-reconciler/cjs/react-reconciler.profiling.min.js = 99.46 kB 97.33 kB = 30.46 kB 29.80 kB
oss-stable/react-reconciler/cjs/react-reconciler.profiling.min.js = 99.46 kB 97.33 kB = 30.46 kB 29.80 kB
oss-stable-semver/react-art/cjs/react-art.development.js = 661.74 kB 647.37 kB = 143.09 kB 139.75 kB
oss-stable/react-art/cjs/react-art.development.js = 661.74 kB 647.37 kB = 143.09 kB 139.75 kB
oss-experimental/react-reconciler/cjs/react-reconciler.production.min.js = 94.14 kB 92.02 kB = 28.91 kB 28.22 kB
oss-experimental/react-reconciler/cjs/react-reconciler.development.js = 729.13 kB 712.63 kB = 154.75 kB 150.96 kB
oss-stable-semver/react-reconciler/cjs/react-reconciler.development.js = 713.05 kB 696.55 kB = 151.35 kB 147.54 kB
oss-stable/react-reconciler/cjs/react-reconciler.development.js = 713.05 kB 696.55 kB = 151.35 kB 147.54 kB
oss-stable-semver/react-reconciler/cjs/react-reconciler.production.min.js = 91.69 kB 89.57 kB = 28.13 kB 27.48 kB
oss-stable/react-reconciler/cjs/react-reconciler.production.min.js = 91.69 kB 89.57 kB = 28.13 kB 27.48 kB
oss-experimental/react-debug-tools/cjs/react-debug-tools.development.js = 23.40 kB 22.85 kB = 6.20 kB 6.14 kB
oss-stable-semver/react-debug-tools/cjs/react-debug-tools.development.js = 23.40 kB 22.85 kB = 6.20 kB 6.14 kB
oss-stable/react-debug-tools/cjs/react-debug-tools.development.js = 23.40 kB 22.85 kB = 6.20 kB 6.14 kB
oss-experimental/react/cjs/react.production.min.js = 7.83 kB 7.58 kB = 2.99 kB 2.92 kB
facebook-www/React-prod.classic.js = 17.45 kB 16.87 kB = 4.46 kB 4.34 kB
facebook-www/React-profiling.classic.js = 17.45 kB 16.87 kB = 4.46 kB 4.34 kB
facebook-www/React-prod.modern.js = 17.31 kB 16.73 kB = 4.41 kB 4.30 kB
facebook-www/React-profiling.modern.js = 17.31 kB 16.73 kB = 4.41 kB 4.30 kB
facebook-react-native/react/cjs/React-prod.js = 17.18 kB 16.60 kB = 4.37 kB 4.26 kB
facebook-react-native/react/cjs/React-profiling.js = 17.18 kB 16.60 kB = 4.37 kB 4.26 kB
oss-stable-semver/react/cjs/react.production.min.js = 7.12 kB 6.87 kB = 2.82 kB 2.75 kB
oss-stable/react/cjs/react.production.min.js = 7.12 kB 6.87 kB = 2.82 kB 2.75 kB
oss-experimental/react/cjs/react-unstable-shared-subset.production.min.js = 6.55 kB 6.30 kB = 2.68 kB 2.61 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
facebook-www/ReactDOMServer-prod.modern.js = 70.57 kB 70.42 kB = 14.51 kB 14.48 kB
facebook-relay/flight/ReactFlightNativeRelayServer-prod.js = 15.96 kB 15.92 kB = 4.06 kB 4.05 kB
facebook-www/ReactFlightDOMRelayServer-prod.classic.js = 15.55 kB 15.51 kB = 3.97 kB 3.96 kB
facebook-www/ReactFlightDOMRelayServer-prod.modern.js = 15.55 kB 15.51 kB = 3.97 kB 3.96 kB
oss-experimental/react-server-dom-webpack/umd/react-server-dom-webpack-writer.browser.production.min.server.js = 6.86 kB 6.84 kB = 2.91 kB 2.90 kB
oss-stable-semver/react-server-dom-webpack/umd/react-server-dom-webpack-writer.browser.production.min.server.js = 6.86 kB 6.84 kB = 2.91 kB 2.90 kB
oss-stable/react-server-dom-webpack/umd/react-server-dom-webpack-writer.browser.production.min.server.js = 6.86 kB 6.84 kB = 2.91 kB 2.90 kB
facebook-www/ReactDOMServer-dev.classic.js = 152.97 kB 152.55 kB = 38.84 kB 38.71 kB
oss-experimental/react-server/cjs/react-server-flight.production.min.js = 6.83 kB 6.81 kB = 2.87 kB 2.86 kB
oss-stable-semver/react-server/cjs/react-server-flight.production.min.js = 6.83 kB 6.81 kB = 2.87 kB 2.86 kB
oss-stable/react-server/cjs/react-server-flight.production.min.js = 6.83 kB 6.81 kB = 2.87 kB 2.86 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-writer.node.production.min.server.js = 6.66 kB 6.64 kB = 2.79 kB 2.78 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-writer.node.production.min.server.js = 6.66 kB 6.64 kB = 2.79 kB 2.78 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-writer.node.production.min.server.js = 6.66 kB 6.64 kB = 2.79 kB 2.78 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-writer.browser.production.min.server.js = 6.65 kB 6.63 kB = 2.82 kB 2.81 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-writer.browser.production.min.server.js = 6.65 kB 6.63 kB = 2.82 kB 2.81 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-writer.browser.production.min.server.js = 6.65 kB 6.63 kB = 2.82 kB 2.81 kB
facebook-www/ReactDOMServer-prod.classic.js = 47.73 kB 47.59 kB = 11.21 kB 11.17 kB
oss-experimental/react-server/cjs/react-server.production.min.js = 17.48 kB 17.43 kB = 5.96 kB 5.94 kB
oss-stable-semver/react-server/cjs/react-server.production.min.js = 17.36 kB 17.30 kB = 5.92 kB 5.90 kB
oss-stable/react-server/cjs/react-server.production.min.js = 17.36 kB 17.30 kB = 5.92 kB 5.90 kB
oss-experimental/react-server/cjs/react-server.development.js = 117.00 kB 116.57 kB = 28.77 kB 28.61 kB
oss-stable-semver/react-server/cjs/react-server.development.js = 116.44 kB 116.01 kB = 28.60 kB 28.46 kB
oss-stable/react-server/cjs/react-server.development.js = 116.44 kB 116.01 kB = 28.60 kB 28.46 kB
oss-experimental/react/umd/react.development.js = 108.91 kB 107.98 kB = 27.72 kB 27.54 kB
oss-stable-semver/react/umd/react.development.js = 107.97 kB 107.05 kB = 27.60 kB 27.42 kB
oss-stable/react/umd/react.development.js = 107.97 kB 107.05 kB = 27.60 kB 27.42 kB
facebook-www/React-dev.classic.js = 110.34 kB 109.37 kB = 26.90 kB 26.68 kB
facebook-www/React-dev.modern.js = 109.32 kB 108.35 kB = 26.70 kB 26.47 kB
facebook-react-native/react/cjs/React-dev.js = 100.79 kB 99.81 kB = 24.37 kB 24.16 kB
oss-experimental/react/cjs/react.development.js = 85.32 kB 84.44 kB = 22.75 kB 22.54 kB
oss-stable-semver/react/cjs/react.development.js = 84.42 kB 83.54 kB = 22.62 kB 22.39 kB
oss-stable/react/cjs/react.development.js = 84.42 kB 83.54 kB = 22.62 kB 22.39 kB
oss-experimental/react/cjs/react-unstable-shared-subset.development.js = 71.05 kB 70.17 kB = 19.32 kB 19.11 kB
facebook-www/ReactDOM-profiling.classic.js = 437.14 kB 431.49 kB = 80.53 kB 79.52 kB
facebook-www/ReactDOMForked-profiling.classic.js = 437.14 kB 431.49 kB = 80.53 kB 79.52 kB
oss-experimental/react-suspense-test-utils/cjs/react-suspense-test-utils.js = 2.65 kB 2.61 kB = 1.10 kB 1.09 kB
oss-stable-semver/react-suspense-test-utils/cjs/react-suspense-test-utils.js = 2.65 kB 2.61 kB = 1.10 kB 1.09 kB
oss-stable/react-suspense-test-utils/cjs/react-suspense-test-utils.js = 2.65 kB 2.61 kB = 1.10 kB 1.09 kB
facebook-www/ReactDOM-profiling.modern.js = 425.65 kB 420.02 kB = 78.83 kB 77.83 kB
facebook-www/ReactDOMForked-profiling.modern.js = 425.65 kB 420.02 kB = 78.84 kB 77.84 kB
oss-experimental/react-art/umd/react-art.production.min.js = 120.89 kB 119.29 kB = 37.55 kB 37.03 kB
oss-stable-semver/react-art/umd/react-art.production.min.js = 118.50 kB 116.90 kB = 36.82 kB 36.28 kB
oss-stable/react-art/umd/react-art.production.min.js = 118.50 kB 116.90 kB = 36.82 kB 36.28 kB
facebook-www/ReactDOM-prod.classic.js = 410.86 kB 405.21 kB = 76.01 kB 74.99 kB
facebook-www/ReactDOMForked-prod.classic.js = 410.86 kB 405.21 kB = 76.01 kB 74.99 kB
facebook-www/ReactDOMTesting-prod.classic.js = 401.32 kB 395.69 kB = 75.65 kB 74.61 kB
facebook-www/ReactDOM-prod.modern.js = 399.43 kB 393.80 kB = 74.29 kB 73.28 kB
facebook-www/ReactDOMForked-prod.modern.js = 399.43 kB 393.80 kB = 74.30 kB 73.28 kB
facebook-www/ReactDOMTesting-prod.modern.js = 388.07 kB 382.45 kB = 73.58 kB 72.54 kB
oss-experimental/react-dom/cjs/react-dom.profiling.min.js = 140.00 kB 137.89 kB = 44.61 kB 43.84 kB
oss-experimental/react-dom/umd/react-dom.profiling.min.js = 140.06 kB 137.95 kB = 45.34 kB 44.61 kB
react-native/implementations/ReactNativeRenderer-profiling.fb.js = 304.08 kB 299.48 kB = 54.63 kB 53.68 kB
facebook-www/ReactDOMTesting-dev.classic.js = 981.15 kB 966.24 kB = 219.97 kB 216.63 kB
react-native/implementations/ReactNativeRenderer-profiling.js = 301.24 kB 296.64 kB = 53.94 kB 52.99 kB
react-native/implementations/ReactFabric-profiling.fb.js = 300.24 kB 295.64 kB = 53.76 kB 52.84 kB
oss-stable-semver/react-dom/cjs/react-dom.profiling.min.js = 137.16 kB 135.05 kB = 43.62 kB 42.92 kB
oss-stable/react-dom/cjs/react-dom.profiling.min.js = 137.16 kB 135.05 kB = 43.62 kB 42.92 kB
oss-stable-semver/react-dom/umd/react-dom.profiling.min.js = 137.26 kB 135.14 kB = 44.46 kB 43.75 kB
oss-stable/react-dom/umd/react-dom.profiling.min.js = 137.26 kB 135.14 kB = 44.46 kB 43.75 kB
facebook-www/ReactDOM-dev.classic.js = 1,077.03 kB 1,060.24 kB = 238.38 kB 234.44 kB
facebook-www/ReactDOMForked-dev.classic.js = 1,077.03 kB 1,060.23 kB = 238.38 kB 234.44 kB
facebook-www/ReactDOMTesting-dev.modern.js = 954.08 kB 939.17 kB = 214.32 kB 211.00 kB
react-native/implementations/ReactFabric-profiling.js = 292.68 kB 288.07 kB = 52.29 kB 51.37 kB
oss-experimental/react-dom/umd/react-dom.production.min.js = 132.41 kB 130.31 kB = 42.97 kB 42.30 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 132.31 kB 130.20 kB = 42.21 kB 41.50 kB
facebook-www/ReactDOM-dev.modern.js = 1,052.59 kB 1,035.79 kB = 233.38 kB 229.48 kB
facebook-www/ReactDOMForked-dev.modern.js = 1,052.59 kB 1,035.79 kB = 233.38 kB 229.48 kB
react-native/implementations/ReactNativeRenderer-prod.fb.js = 286.15 kB 281.55 kB = 51.63 kB 50.77 kB
react-native/implementations/ReactNativeRenderer-prod.js = 283.30 kB 278.70 kB = 50.96 kB 50.09 kB
oss-stable-semver/react-dom/cjs/react-dom.production.min.js = 129.49 kB 127.38 kB = 41.26 kB 40.58 kB
oss-stable/react-dom/cjs/react-dom.production.min.js = 129.49 kB 127.38 kB = 41.26 kB 40.58 kB
oss-experimental/react-dom/umd/react-dom.development.js = 1,047.65 kB 1,030.58 kB = 226.41 kB 222.62 kB
react-native/implementations/ReactFabric-prod.fb.js = 282.31 kB 277.71 kB = 50.75 kB 49.83 kB
oss-stable-semver/react-dom/umd/react-dom.production.min.js = 129.63 kB 127.52 kB = 42.07 kB 41.39 kB
oss-stable/react-dom/umd/react-dom.production.min.js = 129.63 kB 127.52 kB = 42.07 kB 41.39 kB
oss-experimental/react-dom/cjs/react-dom.development.js = 997.11 kB 980.74 kB = 223.80 kB 220.00 kB
facebook-www/ReactART-prod.classic.js = 267.74 kB 263.33 kB = 47.77 kB 46.90 kB
oss-stable-semver/react-dom/umd/react-dom.development.js = 1,028.84 kB 1,011.78 kB = 222.69 kB 218.89 kB
oss-stable/react-dom/umd/react-dom.development.js = 1,028.84 kB 1,011.78 kB = 222.69 kB 218.89 kB
oss-stable-semver/react-dom/cjs/react-dom.development.js = 979.26 kB 962.89 kB = 220.10 kB 216.28 kB
oss-stable/react-dom/cjs/react-dom.development.js = 979.26 kB 962.89 kB = 220.10 kB 216.28 kB
react-native/implementations/ReactFabric-prod.js = 274.78 kB 270.17 kB = 49.30 kB 48.44 kB
facebook-www/ReactART-prod.modern.js = 260.07 kB 255.67 kB = 46.51 kB 45.65 kB
react-native/implementations/ReactNativeRenderer-dev.js = 730.52 kB 717.69 kB = 158.17 kB 155.31 kB
react-native/implementations/ReactFabric-dev.js = 713.38 kB 700.54 kB = 154.25 kB 151.44 kB
facebook-react-native/react-test-renderer/cjs/ReactTestRenderer-profiling.js = 253.25 kB 248.64 kB = 46.12 kB 45.17 kB
oss-experimental/react-art/cjs/react-art.production.min.js = 84.97 kB 83.36 kB = 26.37 kB 25.87 kB
oss-experimental/react-art/umd/react-art.development.js = 782.24 kB 767.26 kB = 164.96 kB 161.60 kB
facebook-react-native/react-test-renderer/cjs/ReactTestRenderer-prod.js = 238.66 kB 234.05 kB = 43.70 kB 42.84 kB
oss-stable-semver/react-art/cjs/react-art.production.min.js = 82.58 kB 80.98 kB = 25.58 kB 25.06 kB
oss-stable/react-art/cjs/react-art.production.min.js = 82.58 kB 80.98 kB = 25.58 kB 25.06 kB
oss-experimental/react-test-renderer/umd/react-test-renderer.production.min.js = 82.02 kB 80.42 kB = 25.78 kB 25.20 kB
react-native/implementations/ReactNativeRenderer-dev.fb.js = 750.50 kB 735.82 kB = 161.95 kB 158.56 kB
oss-stable-semver/react-art/umd/react-art.development.js = 765.51 kB 750.53 kB = 161.56 kB 158.21 kB
oss-stable/react-art/umd/react-art.development.js = 765.51 kB 750.53 kB = 161.56 kB 158.21 kB
oss-experimental/react-test-renderer/cjs/react-test-renderer.production.min.js = 81.82 kB 80.21 kB = 25.33 kB 24.81 kB
oss-experimental/react-debug-tools/cjs/react-debug-tools.production.min.js = 6.89 kB 6.76 kB = 2.61 kB 2.58 kB
oss-stable-semver/react-debug-tools/cjs/react-debug-tools.production.min.js = 6.89 kB 6.76 kB = 2.61 kB 2.58 kB
oss-stable/react-debug-tools/cjs/react-debug-tools.production.min.js = 6.89 kB 6.76 kB = 2.61 kB 2.58 kB
oss-experimental/react-test-renderer/umd/react-test-renderer.development.js = 658.46 kB 645.35 kB = 138.19 kB 135.37 kB
react-native/implementations/ReactFabric-dev.fb.js = 735.38 kB 720.69 kB = 158.57 kB 155.17 kB
oss-experimental/react-test-renderer/cjs/react-test-renderer.development.js = 627.74 kB 615.18 kB = 136.69 kB 133.92 kB
oss-experimental/react/umd/react.production.min.js = 11.82 kB 11.58 kB = 4.63 kB 4.57 kB
oss-experimental/react/umd/react.profiling.min.js = 11.82 kB 11.58 kB = 4.63 kB 4.57 kB
oss-stable-semver/react-test-renderer/umd/react-test-renderer.production.min.js = 79.65 kB 78.04 kB = 24.92 kB 24.41 kB
oss-stable/react-test-renderer/umd/react-test-renderer.production.min.js = 79.65 kB 78.04 kB = 24.92 kB 24.41 kB
oss-stable-semver/react-test-renderer/cjs/react-test-renderer.production.min.js = 79.44 kB 77.83 kB = 24.58 kB 24.07 kB
oss-stable/react-test-renderer/cjs/react-test-renderer.production.min.js = 79.44 kB 77.83 kB = 24.58 kB 24.07 kB
facebook-www/ReactTestRenderer-dev.modern.js = 634.10 kB 621.22 kB = 135.59 kB 132.75 kB
facebook-www/ReactTestRenderer-dev.classic.js = 634.09 kB 621.21 kB = 135.58 kB 132.74 kB
facebook-www/ReactART-dev.classic.js = 726.55 kB 711.79 kB = 154.78 kB 151.38 kB
oss-stable-semver/react-test-renderer/umd/react-test-renderer.development.js = 641.77 kB 628.66 kB = 134.77 kB 132.00 kB
oss-stable/react-test-renderer/umd/react-test-renderer.development.js = 641.77 kB 628.66 kB = 134.77 kB 132.00 kB
oss-stable-semver/react-test-renderer/cjs/react-test-renderer.development.js = 611.89 kB 599.33 kB = 133.34 kB 130.53 kB
oss-stable/react-test-renderer/cjs/react-test-renderer.development.js = 611.89 kB 599.33 kB = 133.34 kB 130.53 kB
facebook-www/ReactART-dev.modern.js = 716.27 kB 701.51 kB = 152.64 kB 149.25 kB
facebook-react-native/react-test-renderer/cjs/ReactTestRenderer-dev.js = 622.63 kB 609.78 kB = 134.36 kB 131.49 kB
oss-experimental/react-reconciler/cjs/react-reconciler.profiling.min.js = 101.93 kB 99.80 kB = 31.20 kB 30.53 kB
oss-stable-semver/react/umd/react.production.min.js = 11.18 kB 10.94 kB = 4.47 kB 4.40 kB
oss-stable/react/umd/react.production.min.js = 11.18 kB 10.94 kB = 4.47 kB 4.40 kB
oss-stable-semver/react/umd/react.profiling.min.js = 11.18 kB 10.94 kB = 4.47 kB 4.40 kB
oss-stable/react/umd/react.profiling.min.js = 11.18 kB 10.94 kB = 4.47 kB 4.40 kB
oss-experimental/react-art/cjs/react-art.development.js = 677.62 kB 663.25 kB = 146.49 kB 143.18 kB
oss-stable-semver/react-reconciler/cjs/react-reconciler.profiling.min.js = 99.46 kB 97.33 kB = 30.46 kB 29.80 kB
oss-stable/react-reconciler/cjs/react-reconciler.profiling.min.js = 99.46 kB 97.33 kB = 30.46 kB 29.80 kB
oss-stable-semver/react-art/cjs/react-art.development.js = 661.74 kB 647.37 kB = 143.09 kB 139.75 kB
oss-stable/react-art/cjs/react-art.development.js = 661.74 kB 647.37 kB = 143.09 kB 139.75 kB
oss-experimental/react-reconciler/cjs/react-reconciler.production.min.js = 94.14 kB 92.02 kB = 28.91 kB 28.22 kB
oss-experimental/react-reconciler/cjs/react-reconciler.development.js = 729.13 kB 712.63 kB = 154.75 kB 150.96 kB
oss-stable-semver/react-reconciler/cjs/react-reconciler.development.js = 713.05 kB 696.55 kB = 151.35 kB 147.54 kB
oss-stable/react-reconciler/cjs/react-reconciler.development.js = 713.05 kB 696.55 kB = 151.35 kB 147.54 kB
oss-stable-semver/react-reconciler/cjs/react-reconciler.production.min.js = 91.69 kB 89.57 kB = 28.13 kB 27.48 kB
oss-stable/react-reconciler/cjs/react-reconciler.production.min.js = 91.69 kB 89.57 kB = 28.13 kB 27.48 kB
oss-experimental/react-debug-tools/cjs/react-debug-tools.development.js = 23.40 kB 22.85 kB = 6.20 kB 6.14 kB
oss-stable-semver/react-debug-tools/cjs/react-debug-tools.development.js = 23.40 kB 22.85 kB = 6.20 kB 6.14 kB
oss-stable/react-debug-tools/cjs/react-debug-tools.development.js = 23.40 kB 22.85 kB = 6.20 kB 6.14 kB
oss-experimental/react/cjs/react.production.min.js = 7.83 kB 7.58 kB = 2.99 kB 2.92 kB
facebook-www/React-prod.classic.js = 17.45 kB 16.87 kB = 4.46 kB 4.34 kB
facebook-www/React-profiling.classic.js = 17.45 kB 16.87 kB = 4.46 kB 4.34 kB
facebook-www/React-prod.modern.js = 17.31 kB 16.73 kB = 4.41 kB 4.30 kB
facebook-www/React-profiling.modern.js = 17.31 kB 16.73 kB = 4.41 kB 4.30 kB
facebook-react-native/react/cjs/React-prod.js = 17.18 kB 16.60 kB = 4.37 kB 4.26 kB
facebook-react-native/react/cjs/React-profiling.js = 17.18 kB 16.60 kB = 4.37 kB 4.26 kB
oss-stable-semver/react/cjs/react.production.min.js = 7.12 kB 6.87 kB = 2.82 kB 2.75 kB
oss-stable/react/cjs/react.production.min.js = 7.12 kB 6.87 kB = 2.82 kB 2.75 kB
oss-experimental/react/cjs/react-unstable-shared-subset.production.min.js = 6.55 kB 6.30 kB = 2.68 kB 2.61 kB

Generated by 🚫 dangerJS against 2bd76f8

const value = getSnapshot(source._source);
hookLog.push({primitive: 'MutableSource', stackError: new Error(), value});
return value;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't be deleted from debug hooks, should it? That affects DevTools, which has to support versions of React that had (unstable) useMutableSource.

Copy link
Contributor

@bvaughn bvaughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is the first built-in hook that we've deleted, but I think we need to talk about about react-debug-tools handles such things going forward.

@acdlite
Copy link
Collaborator Author

acdlite commented Sep 10, 2021

This shouldn't be deleted from debug hooks, should it? That affects DevTools, which has to support versions of React that had (unstable) useMutableSource.

I assumed that since it was never stable, we don't have to support it indefinitely

@bvaughn
Copy link
Contributor

bvaughn commented Sep 10, 2021

This shouldn't be deleted from debug hooks, should it? That affects DevTools, which has to support versions of React that had (unstable) useMutableSource.

I assumed that since it was never stable, we don't have to support it indefinitely

I think the cost of deleting this will be that DevTools throws an error if you ever inspect a component built with an alpha release that uses it.

Let's add this topic to Monday's sync?

@gaearon
Copy link
Collaborator

gaearon commented Sep 10, 2021

Does Recoil use it?

@windmaomao
Copy link

Does Recoil use it?

I remember you guys mentioned before seems redux uses it as well?

@acdlite
Copy link
Collaborator Author

acdlite commented Sep 14, 2021

Recoil does use it but not before checking if the API exists

If they didn’t do that, Recoil would only work with experimental React builds.

Copy link
Contributor

@bvaughn bvaughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing my objection here after discussion today.

This API was replaced by useSyncExternalStore
@acdlite acdlite force-pushed the delete-usemutablesource branch 3 times, most recently from 0ec711f to 2bd76f8 Compare September 20, 2021 03:40
@acdlite acdlite marked this pull request as ready for review September 20, 2021 04:10
@acdlite acdlite merged commit 8209de2 into facebook:main Sep 20, 2021
facebook-github-bot pushed a commit to facebook/react-native that referenced this pull request Oct 12, 2021
Summary:
This sync includes the following changes:
- **[579c008a7](facebook/react@579c008a7 )**: [Fizz/Flight] pipeToNodeWritable(..., writable).startWriting() -> renderToPipeableStream(...).pipe(writable) ([#22450](facebook/react#22450)) //<Sebastian Markbåge>//
- **[f2c381131](facebook/react@f2c381131 )**: fix: useSyncExternalStoreExtra ([#22500](facebook/react#22500)) //<Daishi Kato>//
- **[0ecbbe142](facebook/react@0ecbbe142 )**: Sync hydrate discrete events in capture phase and dont replay discrete events ([#22448](facebook/react#22448)) //<salazarm>//
- **[a724a3b57](facebook/react@a724a3b57 )**: [RFC] Codemod invariant -> throw new Error ([#22435](facebook/react#22435)) //<Andrew Clark>//
- **[201af81b0](facebook/react@201af81b0 )**: Release pooled cache reference in complete/unwind ([#22464](facebook/react#22464)) //<Joseph Savona>//
- **[033efe731](facebook/react@033efe731 )**: Call get snapshot in useSyncExternalStore server shim ([#22453](facebook/react#22453)) //<salazarm>//
- **[7843b142a](facebook/react@7843b142a )**: [Fizz/Flight] Pass in Destination lazily to startFlowing instead of in createRequest ([#22449](facebook/react#22449)) //<Sebastian Markbåge>//
- **[d9fb383d6](facebook/react@d9fb383d6 )**: Extract queueing logic into shared functions ([#22452](facebook/react#22452)) //<Andrew Clark>//
- **[9175f4d15](facebook/react@9175f4d15 )**: Scheduling Profiler: Show Suspense resource .displayName ([#22451](facebook/react#22451)) //<Brian Vaughn>//
- **[eba248c39](facebook/react@eba248c39 )**: [Fizz/Flight] Remove reentrancy hack ([#22446](facebook/react#22446)) //<Sebastian Markbåge>//
- **[66388150e](facebook/react@66388150e )**: Remove usereducer eager bailout ([#22445](facebook/react#22445)) //<Joseph Savona>//
- **[d3e086932](facebook/react@d3e086932 )**: Make root.unmount() synchronous  ([#22444](facebook/react#22444)) //<Andrew Clark>//
- **[2cc6d79c9](facebook/react@2cc6d79c9 )**: Rename onReadyToStream to onCompleteShell ([#22443](facebook/react#22443)) //<Sebastian Markbåge>//
- **[c88fb49d3](facebook/react@c88fb49d3 )**: Improve DEV errors if string coercion throws (Temporal.*, Symbol, etc.) ([#22064](facebook/react#22064)) //<Justin Grant>//
- **[05726d72c](facebook/react@05726d72c )**: [Fix] Errors should not "unsuspend" a transition ([#22423](facebook/react#22423)) //<Andrew Clark>//
- **[3746eaf98](facebook/react@3746eaf98 )**: Packages/React/src/ReactLazy ---> changing -1 to unintialized ([#22421](facebook/react#22421)) //<BIKI DAS>//
- **[04ccc01d9](facebook/react@04ccc01d9 )**: Hydration errors should force a client render ([#22416](facebook/react#22416)) //<Andrew Clark>//
- **[029fdcebb](facebook/react@029fdcebb )**: root.hydrate -> root.isDehydrated ([#22420](facebook/react#22420)) //<Andrew Clark>//
- **[af87f5a83](facebook/react@af87f5a83 )**: Scheduling Profiler marks should include thrown Errors ([#22417](facebook/react#22417)) //<Brian Vaughn>//
- **[d47339ea3](facebook/react@d47339ea3 )**: [Fizz] Remove assignID mechanism ([#22410](facebook/react#22410)) //<Sebastian Markbåge>//
- **[3a50d9557](facebook/react@3a50d9557 )**: Never attach ping listeners in legacy Suspense ([#22407](facebook/react#22407)) //<Andrew Clark>//
- **[82c8fa90b](facebook/react@82c8fa90b )**: Add back useMutableSource temporarily ([#22396](facebook/react#22396)) //<Andrew Clark>//
- **[5b57bc6e3](facebook/react@5b57bc6e3 )**: [Draft] don't patch console during first render ([#22308](facebook/react#22308)) //<Luna Ruan>//
- **[cf07c3df1](facebook/react@cf07c3df1 )**: Delete all but one `build2` reference ([#22391](facebook/react#22391)) //<Andrew Clark>//
- **[bb0d06935](facebook/react@bb0d06935 )**: [build2 -> build] Local scripts //<Andrew Clark>//
- **[0c81d347b](facebook/react@0c81d347b )**: Write artifacts to `build` instead of `build2` //<Andrew Clark>//
- **[4da03c9fb](facebook/react@4da03c9fb )**: useSyncExternalStore React Native version ([#22367](facebook/react#22367)) //<salazarm>//
- **[48d475c9e](facebook/react@48d475c9e )**: correct typos ([#22294](facebook/react#22294)) //<Bowen>//
- **[cb6c619c0](facebook/react@cb6c619c0 )**: Remove Fiber fields that were used for hydrating useMutableSource ([#22368](facebook/react#22368)) //<Sebastian Silbermann>//
- **[64e70f82e](facebook/react@64e70f82e )**: [Fizz] add avoidThisFallback support ([#22318](facebook/react#22318)) //<salazarm>//
- **[3ee7a004e](facebook/react@3ee7a004e )**: devtools: Display actual ReactDOM API name in root type ([#22363](facebook/react#22363)) //<Sebastian Silbermann>//
- **[79b8fc667](facebook/react@79b8fc667 )**: Implement getServerSnapshot in userspace shim ([#22359](facebook/react#22359)) //<Andrew Clark>//
- **[86b3e2461](facebook/react@86b3e2461 )**: Implement useSyncExternalStore on server ([#22347](facebook/react#22347)) //<Andrew Clark>//
- **[8209de269](facebook/react@8209de269 )**: Delete useMutableSource implementation ([#22292](facebook/react#22292)) //<Andrew Clark>//

Changelog:
[General][Changed] - React Native sync for revisions e8feb11...afcb9cd

jest_e2e[run_all_tests]

Reviewed By: yungsters

Differential Revision: D31541359

fbshipit-source-id: c35941bc303fdf55cb061e9996200dc868a6f2af
@Jack-Works
Copy link
Contributor

Is it deleted? Why I can see it in the latest alpha build? 🤔
image

@eps1lon
Copy link
Collaborator

eps1lon commented Oct 21, 2021

Is it deleted? Why I can see it in the latest alpha build? thinking image

@Jack-Works It was restored temporarily in #22396

acdlite added a commit to acdlite/react that referenced this pull request Nov 1, 2021
I had to revert facebook#22292 because there are some internal callers of
useMutableSource that we haven't migrated yet. This removes
useMutableSource from the open source build but keeps it in the
internal one.
acdlite added a commit to acdlite/react that referenced this pull request Nov 1, 2021
I had to revert facebook#22292 because there are some internal callers of
useMutableSource that we haven't migrated yet. This removes
useMutableSource from the open source build but keeps it in the
internal one.
acdlite added a commit to acdlite/react that referenced this pull request Nov 1, 2021
I had to revert facebook#22292 because there are some internal callers of
useMutableSource that we haven't migrated yet. This removes
useMutableSource from the open source build but keeps it in the
internal one.
acdlite added a commit to acdlite/react that referenced this pull request Nov 1, 2021
I had to revert facebook#22292 because there are some internal callers of
useMutableSource that we haven't migrated yet. This removes
useMutableSource from the open source build but keeps it in the
internal one.
acdlite added a commit that referenced this pull request Nov 1, 2021
I had to revert #22292 because there are some internal callers of
useMutableSource that we haven't migrated yet. This removes
useMutableSource from the open source build but keeps it in the
internal one.
This was referenced Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants