Skip to content

Fix change events for custom elements #22938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gaearon merged 26 commits into from
Jan 19, 2022
Merged

Fix change events for custom elements #22938

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
b5b3a87
Bypass react event system for custom elements
josepharhar Dec 9, 2021
e2bbc6a
Going to try fixing react event system instead
josepharhar Dec 15, 2021
b194a40
finally got it to call onChange, but perhaps too many times
josepharhar Dec 16, 2021
ace371d
update test
josepharhar Dec 16, 2021
0f35e74
Removed ReactDOMComponent changes, now works but still doubles for bu…
josepharhar Dec 16, 2021
82f2ac4
Maybe i should only support bubbling events
josepharhar Dec 23, 2021
2cbbce3
removed some old stuff
josepharhar Dec 24, 2021
952398d
cleaned up changeeventplugin stuff
josepharhar Dec 25, 2021
eb315d7
prettier, lint
josepharhar Dec 25, 2021
9c99902
removed changeeventplugin stuff
josepharhar Dec 25, 2021
5d1e6da
remove unneeded gate for onInput test
josepharhar Dec 25, 2021
a5db602
Go back to using ChangeEventPlugin
josepharhar Jan 13, 2022
9b77933
Add input+change test
josepharhar Jan 13, 2022
34c35e8
Merge with 5 weeks of commits
josepharhar Jan 13, 2022
dd6c930
lint
josepharhar Jan 13, 2022
c4e2dbe
Move logic to shouldUseChangeEvent
josepharhar Jan 14, 2022
741db52
use memoizedProps instead of pendingProps
josepharhar Jan 15, 2022
2d17c97
Run form control behavior before custom element behavior
josepharhar Jan 18, 2022
3f345c8
add bubbling test
josepharhar Jan 18, 2022
41a9ad7
forgot to append container to body
josepharhar Jan 18, 2022
81d4517
add child event target test
josepharhar Jan 18, 2022
69eb020
expand <input is=...> test expectations
josepharhar Jan 18, 2022
6eaf85c
Make tests more realistic
gaearon Jan 19, 2022
c58a742
Add extra test
gaearon Jan 19, 2022
2ab52df
Add missing gating
gaearon Jan 19, 2022
93c9db1
Actually fix gating
gaearon Jan 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading