Skip to content

Conversation

@poteto
Copy link
Member

@poteto poteto commented May 15, 2024

Stack from ghstack (oldest at bottom):

This script needs to run from main since it commits version bumps for
packages, and those need to point to publicly available hashes. So,
throw an error if we're not already on main.

[ghstack-poisoned]
poteto added a commit that referenced this pull request May 15, 2024
This script needs to run from `main` since it commits version bumps for
packages, and those need to point to publicly available hashes. So,
throw an error if we're not already on main.

ghstack-source-id: 8490243
Pull Request resolved: #29083
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels May 15, 2024
poteto added a commit that referenced this pull request May 15, 2024
This script needs to run from `main` since it commits version bumps for
packages, and those need to point to publicly available hashes. So,
throw an error if we're not already on main.

ghstack-source-id: 8490243
Pull Request resolved: #29083
@react-sizebot
Copy link

Comparing: cf7d895...6ca227b

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.66 kB 6.66 kB = 1.82 kB 1.82 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 495.01 kB 495.01 kB = 88.68 kB 88.68 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.67 kB 6.67 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 499.81 kB 499.81 kB = 89.36 kB 89.36 kB
facebook-www/ReactDOM-prod.classic.js = 592.16 kB 592.16 kB = 104.15 kB 104.15 kB
facebook-www/ReactDOM-prod.modern.js = 568.39 kB 568.39 kB = 100.55 kB 100.55 kB
test_utils/ReactAllWarnings.js Deleted 64.26 kB 0.00 kB Deleted 16.02 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
test_utils/ReactAllWarnings.js Deleted 64.26 kB 0.00 kB Deleted 16.02 kB 0.00 kB

Generated by 🚫 dangerJS against 6ca227b

@josephsavona
Copy link
Member

Would be good to also check that there are no local modifications

[ghstack-poisoned]
poteto added a commit that referenced this pull request May 15, 2024
This script needs to run from `main` since it commits version bumps for
packages, and those need to point to publicly available hashes. So,
throw an error if we're not already on main.

ghstack-source-id: ce0168e
Pull Request resolved: #29083
@poteto
Copy link
Member Author

poteto commented May 15, 2024

Would be good to also check that there are no local modifications

Fixed, thanks!

@poteto poteto merged commit bab4927 into gh/poteto/2/base May 15, 2024
poteto added a commit that referenced this pull request May 15, 2024
This script needs to run from `main` since it commits version bumps for
packages, and those need to point to publicly available hashes. So,
throw an error if we're not already on main.

ghstack-source-id: ce0168e
Pull Request resolved: #29083
@poteto poteto deleted the gh/poteto/2/head branch May 15, 2024 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants