Skip to content

[compiler] Remove sleep in manual release script #30613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
poteto merged 2 commits into from
Aug 6, 2024
Merged

[compiler] Remove sleep in manual release script #30613

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8fc837c
Update
poteto Aug 6, 2024
80f21c1
Update
poteto Aug 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 0 additions & 14 deletions compiler/scripts/release/publish-manual.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ const PUBLISHABLE_PACKAGES = [
'eslint-plugin-react-compiler',
'react-compiler-healthcheck',
];
const TIME_TO_RECONSIDER = 3_000;

function _spawn(command, args, options, cb) {
const child = cp.spawn(command, args, options);
Expand All @@ -33,10 +32,6 @@ function execHelper(command, options, streamStdout = false) {
});
}

function sleep(ms) {
return new Promise(resolve => setTimeout(resolve, ms));
}

async function getDateStringForCommit(commit) {
let dateString = await execHelper(
`git show -s --no-show-signature --format=%cd --date=format:%Y%m%d ${commit}`
Expand Down Expand Up @@ -191,15 +186,6 @@ async function main() {
);
}

if (debug === false) {
spinner.info(
`🚨🚨🚨 About to publish to npm in ${
TIME_TO_RECONSIDER / 1000
} seconds. You still have time to kill this script!`
);
await sleep(TIME_TO_RECONSIDER);
}

for (const pkgName of pkgNames) {
const pkgDir = path.resolve(__dirname, `../../packages/${pkgName}`);
console.log(`\n========== ${pkgName} ==========\n`);
Expand Down