Skip to content

[compiler][be] Remove completed todo comment #30633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
josephsavona merged 1 commit into from
Aug 9, 2024
Merged

[compiler][be] Remove completed todo comment #30633

josephsavona merged 1 commit into from
Aug 9, 2024

Conversation

@josephsavona
Copy link
Member

@josephsavona josephsavona commented Aug 8, 2024 •
edited
Loading

Stack from ghstack (oldest at bottom):

We made block types explicit a long time ago, this comment is super stale

@josephsavona
[compiler][be] Remove completed todo comment
2e0e13b 
We made block types explicit a long time ago, this comment is super stale

[ghstack-poisoned]
@vercel
Copy link

vercel bot commented Aug 8, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 8, 2024 5:14am

@josephsavona josephsavona mentioned this pull request Aug 8, 2024
Merged
josephsavona added a commit that referenced this pull request Aug 8, 2024
@josephsavona
[compiler][be] Remove completed todo comment
f570f89 
We made block types explicit a long time ago, this comment is super stale

ghstack-source-id: 810a34b
Pull Request resolved: #30633
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Aug 8, 2024
@josephsavona josephsavona merged commit 2e0e13b into gh/josephsavona/34/base Aug 9, 2024
josephsavona added a commit that referenced this pull request Aug 9, 2024
@josephsavona
[compiler][be] Remove completed todo comment
54a150d 
We made block types explicit a long time ago, this comment is super stale

ghstack-source-id: 810a34b
Pull Request resolved: #30633
@josephsavona josephsavona deleted the gh/josephsavona/34/head branch August 9, 2024 21:11
@eps1lon eps1lon mentioned this pull request Aug 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kassens kassens kassens approved these changes

Assignees

No one assigned

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@josephsavona @kassens @facebook-github-bot