Skip to content

[scripts] yarn flags --equal #31760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[scripts] yarn flags --equal #31760

wants to merge 1 commit into from
+28 −13

Conversation

@rickhanlonii
Copy link
Member

Adds a new option to yarn flags to output only the flags that are equal:

Screenshot 2024-12-13 at 2 28 21 PM

It can also be used with --diff

Screenshot 2024-12-13 at 2 29 34 PM

@vercel
Copy link

vercel bot commented Dec 13, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 13, 2024 7:31pm

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Dec 13, 2024
@react-sizebot
Copy link

Comparing: ef63718...9915b8e

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB +0.05% 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 510.41 kB 510.41 kB = 91.35 kB 91.35 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 515.32 kB 515.32 kB = 92.04 kB 92.04 kB
facebook-www/ReactDOM-prod.classic.js = 595.25 kB 595.25 kB = 105.02 kB 105.02 kB
facebook-www/ReactDOM-prod.modern.js = 585.51 kB 585.51 kB = 103.46 kB 103.46 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 8dd3167

kassens
kassens approved these changes Dec 13, 2024
View reviewed changes
Copy link
Member

@kassens kassens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat

@jackpope jackpope mentioned this pull request Dec 13, 2024
Merged
@rickhanlonii
Copy link
Member Author

This is a better version: #31762

jackpope added a commit that referenced this pull request Dec 13, 2024
@jackpope
Add --cleanup option to flags script to show groups of flags by status (
982cf95 
#31762)

`yarn flags --cleanup` will categorize flags to make it more clear which
ones may need to be cleaned up, experiments checked on, or are blocked
by internal rollouts.

Alternative to #31760

<img width="787" alt="Screenshot 2024-12-13 at 2 31 30 PM"
src="https://github.com/user-attachments/assets/452aee7e-9caf-4210-a621-53941d59cb2b"
/>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kassens kassens kassens approved these changes

Assignees

No one assigned

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rickhanlonii @react-sizebot @kassens @facebook-github-bot