Skip to content

Optimize method calls w props receiver #31771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Optimize method calls w props receiver #31771

wants to merge 2 commits into from

Conversation

@josephsavona
Copy link
Member

@josephsavona josephsavona commented Dec 13, 2024 •
edited
Loading

Stack from ghstack (oldest at bottom):

@vercel
Copy link

vercel bot commented Dec 13, 2024

Deployment failed with the following error:

You don't have permission to create a Preview Deployment for this project.

View Documentation: https://vercel.com/docs/accounts/team-members-and-roles

josephsavona added a commit that referenced this pull request Dec 13, 2024
@josephsavona
Optimize method calls w props receiver
32b81a3 
ghstack-source-id: 6a49070
Pull Request resolved: #31771
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Dec 13, 2024
@josephsavona
Copy link
Member Author

Closes #31763

mofeiZ
mofeiZ reviewed Dec 13, 2024
View reviewed changes
...in-react-compiler/src/__tests__/fixtures/compiler/jsx-outlining-child-stored-in-id.expect.md Outdated

```javascript
import { c as _c } from "react/compiler-runtime"; // @enableJsxOutlining
function Component(arr) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: can we rewrite this fixture to destructure props i.e. function Component({ arr })?

mofeiZ
mofeiZ reviewed Dec 13, 2024
View reviewed changes
...abel-plugin-react-compiler/src/__tests__/fixtures/compiler/props-method-dependency.expect.md Outdated
```
### Eval output
(kind: exception) Fixture not implemented No newline at end of file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: could we add a FIXTURE_ENTRYPOINT export here?

mofeiZ
mofeiZ approved these changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@mofeiZ mofeiZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!!

josephsavona added a commit that referenced this pull request Dec 14, 2024
@josephsavona
Optimize method calls w props receiver
bf31bce 
ghstack-source-id: 9c6361d
Pull Request resolved: #31771
This was referenced Dec 14, 2024
Closed
Merged
josephsavona added a commit that referenced this pull request Dec 14, 2024
@josephsavona
Optimize method calls w props receiver (#31775)
a1b3bd0 
Redo of #31771 without ghstack
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mofeiZ mofeiZ mofeiZ approved these changes

Assignees

No one assigned

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@josephsavona @mofeiZ @facebook-github-bot