Skip to content

Conversation

@poteto
Copy link
Member

@poteto poteto commented Jan 6, 2025

The compiler playground already installs the compiler's dependencies in a preinstall step. No need to repeat it in CI.

Stack created with Sapling. Best reviewed with ReviewStack.

poteto added 2 commits January 6, 2025 10:50
This was accidentally removed in the esbuild transition.
The compiler playground already installs the compiler's dependencies in a preinstall step. No need to repeat it in CI.
@vercel
Copy link

vercel bot commented Jan 6, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 6, 2025 3:59pm

@poteto poteto mentioned this pull request Jan 6, 2025
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Jan 6, 2025
@react-sizebot
Copy link

Comparing: 9627d71...e66fd2d

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB +0.05% 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 512.56 kB 512.56 kB = 91.61 kB 91.61 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 517.34 kB 517.34 kB = 92.46 kB 92.46 kB
facebook-www/ReactDOM-prod.classic.js = 594.36 kB 594.36 kB = 104.68 kB 104.69 kB
facebook-www/ReactDOM-prod.modern.js = 584.62 kB 584.62 kB = 103.14 kB 103.14 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 2290854

poteto added a commit that referenced this pull request Jan 6, 2025
This was accidentally removed in the esbuild transition.

---
[//]: # (BEGIN SAPLING FOOTER)
Stack created with [Sapling](https://sapling-scm.com). Best reviewed
with [ReviewStack](https://reviewstack.dev/facebook/react/pull/31994).
* #31995
* __->__ #31994
@poteto poteto merged commit 3ce77d5 into main Jan 6, 2025
200 checks passed
@poteto poteto deleted the pr31995 branch January 6, 2025 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants